Re: [PATCH v2 2/9] media: qcom: camss: Introduce SOF sequence tracking

[Bryan O'Donoghue <bod@kernel.org>]

On 03/11/2026 13:13, Gjorgji Rosikopulos (Consultant) wrote:
>>> More than that though, there is in-fact a VFE specific SOF/EOF and EPOCH
>>> event but these require the CSID feeding a frame into the VFE pipeline
>>> and the VFE moving through its own state-machine to process that frame.
>>>
>>> So they are separate signals and separate logical events representing
>>> different things with different timings in hardware, meaning different
>>> things to userspace.
>> Well that make sense i agree that it make sense to be part of the csid
>> but it should be documented somewhere, maybe proper thing to do is update
>> the comment in videodev2.h and update the documentation for camss driver.
> Just an proposal if it is decided the id to be used, it make sense to contain
> stream_id. Then userspace based on the stream routing can map SOF
> for the stream of interest. But the API for retrieving stream_id is still
> experimental and i am not sure if will be well accepted.
> 

Ah yes right I didn't really grok your point about .id = <integer> yes I 
agree with you, the assignment of port/line number should be dropped and 
left @ 0 - also what is the point of stuffing the line id into the .id 
field is not warranted.

Agreed, that's a mistake.

---
bod