From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB3E33B52F0 for ; Fri, 3 Apr 2026 11:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775217574; cv=none; b=b2kJeGRzZqSqTuWT45v1bP2SU/HgwBII/ohH/cOtLqLvffWgJJoneF24krck0iiM949w1mgKT/fov/IOAAZqszvKggq0GNQ74oCm4atvJDFspgurfM4PTdRjwOC3mJRsNvWOAEeHZv04S19AvQr7h9E9yOuCsFtuPuK+eG4nk7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775217574; c=relaxed/simple; bh=DkiKVfGKmwuAwr2izbdAbcwMKG7G5cWwKW7/OtXtPjA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dD0EulBWmkWL92DmXon6XNigE5upF3Rm99ZfGQoVjLli0ss+X2z5hlHSRKeEN07nUJjIZkwAxO61lG0L5gDDVq5MR2LXhj4BFJ6pt6Rkzkhne6fuDlRMeA2M1ChWavesFs0/ZSp8o1PrSAF9GuzKYdzpIOMOPcdcfWkL+9Kf0YA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Zu6050+v; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JmA//ptx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Zu6050+v"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JmA//ptx" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6336E10X3772909 for ; Fri, 3 Apr 2026 11:59:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rIB07DV1tdm7k7+UufYs3koTVO8ALZL6SbpGjd2EXmw=; b=Zu6050+v33fSurYb B79waiPVN101Mz2YzL1sxEtcUB/b5HUnle+CaoW9IGjl6l8jxkDSHJeoGi1126W+ p0AuZFDvN2jjcjrmlOipi+oejSILpSvp8AXk+GDxj0txNLK4C89uLo/idK/A9DPF NUZmM/4HHf4iUoGgtoNmGheeZhrZeYOTV4xwZyHuhW36/nlqiJjboj/H7Y1EryEZ VzO8BFW0a/ILZ5ICGP/G569lIIuPt7xZiKA2QRg0FPavOq+O9YZQi4mTGHaIoWLT RGRNg2DofWZPINLIuqSrD/7/POo4h+MjTZK28ecvvfUSorNoMDh+3xeAv9LSAuZ9 bphxhQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d9wcs2stp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Apr 2026 11:59:31 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35678f99c6eso1354399a91.1 for ; Fri, 03 Apr 2026 04:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775217571; x=1775822371; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rIB07DV1tdm7k7+UufYs3koTVO8ALZL6SbpGjd2EXmw=; b=JmA//ptxkNzX5hnrzzZIXp1YG8oDm9ql/HrtDR8JzCwP4UtmmhY3upg3yF7jRBkzXk 0iSaZbmRGvy8NaSJfE0kGMyjMAyuCHEUmvqIv2fb4EEyzT4ilXm1ER6pp3BS6GOYtV3m j3Ocf3gZv6YBagNbSfgx9PAI6+MBOzKdhjL6cjMNQtlqTreBI40vIIULyG2jM8HWhkWu gpEeh4Ix7hfZHRnzK50u7hLMM1bUYTWaUVLQ7ruTwIBLyDlcuYL+UIcXjxKypq4Osg/h ezyfZrSWSltIk+PY5FpVirPzlFx0++ozeAPe+hrzSgJ8A4H00tZI4O1Itz8SOYl+d+7A kfbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775217571; x=1775822371; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rIB07DV1tdm7k7+UufYs3koTVO8ALZL6SbpGjd2EXmw=; b=D8kvaZ03PsusiXBtOayj6QS1NueWOSX9moaVxKhYnWxbn3kO21EYd37R1+tvRjPI3Z 2ioYLbMPSOfNtArf9kUP4UV0rW/r2kmDk2aSeJWlOMbKbDZoOlJR+MbRWZHjlFfCL9lV b4rmUDW9KOl7q86v8vrJCAUEjPLUl2dsaqv3HTmgnQNTavEd8fUoy9F05rdZVsTN1uad WabNX0z+SYZUiZRRgW06kW6j8EE9NrvlOozafmVmi6eN1f/j8/Onk8wzVRokEvL1NQ8E tcDUo75f+VTi9oRSOygk6DdaSJq4Vu1G2uB8fcwzXL+kT3cdUN3eXEmAQwvJmpaGovT7 3zxw== X-Forwarded-Encrypted: i=1; AJvYcCWiHfH0+q2KEDq6SPw04rkj0bIhMYkH/nqQ+SRocqiLQo+weOdrHLwJJtrZM5cH9hlN1uyuyN+DvVEqw2A=@vger.kernel.org X-Gm-Message-State: AOJu0YzRf69XtbZ41JDIrd6QZdX0ghlpMZGIXRzKR28B22qhlLHaH0uU Ab+c//SiCqPWszJe88xniS62ZyR893xa9hdYcoo8cjsANYLJNk2/HXaylDu4jxD0xMc9LkUIWzn /M0DjlkRrptiU1p3iZGHnaOCM+HR30dzl6Tx1qJY4bxNGNlWMm0YFvJSeuIHoQwo9yKA= X-Gm-Gg: AeBDievBV5L+6MZO53l8Q/t9s9VCyIFG7N+0YHsPDc7+19V2Y6ckZJdvmRtCzvwuUPr /5+XhmgxTugMGe39KUYTKYwPv+djYnvp/Rr/M+FPEmWf/chOedRjQGs9LOSGxY2kKdVOwQGCZdE 0DqREBAQLqEsMPAQdIt9xV9c6NBnyMTXncg16e6JzEUnG0ni+doikT8RFVHRUqDTdZ49teHj+aE 7V9I1zI7B7DzyIzMQb+LNwO3pbTkQFz+KabSwuwMFE4I06gg2fmtqks4SVryFcIvQ4ptorneU8I 6/C1sOWz7AblCMpanzupA7HElWUNe5iiHDnkbsbMJV+kZm9TQBNtME1NpOJqil3yfDGRPl9Tum6 dy0qBiUZHCoOD7xd4S1GuD9DBr3IVSs3vY9pcdbg4plFj0g4aW+s= X-Received: by 2002:a17:90b:3c0c:b0:336:b60f:3936 with SMTP id 98e67ed59e1d1-35de680b3efmr2179738a91.12.1775217570580; Fri, 03 Apr 2026 04:59:30 -0700 (PDT) X-Received: by 2002:a17:90b:3c0c:b0:336:b60f:3936 with SMTP id 98e67ed59e1d1-35de680b3efmr2179717a91.12.1775217570111; Fri, 03 Apr 2026 04:59:30 -0700 (PDT) Received: from [10.92.178.97] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe9709b8sm10103955a91.16.2026.04.03.04.59.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2026 04:59:29 -0700 (PDT) Message-ID: <57aa580b-c7a5-4cba-af5c-bce3d692310d@oss.qualcomm.com> Date: Fri, 3 Apr 2026 17:29:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 2/2] ufs: ufs-qcom: Enable Auto Hibern8 clock request support To: Bart Van Assche , mani@kernel.org, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, shawn.lin@rock-chips.com, nitin.rawat@oss.qualcomm.com References: <20260327090346.656324-1-palash.kambar@oss.qualcomm.com> <20260327090346.656324-3-palash.kambar@oss.qualcomm.com> <97050b9c-7174-4402-a1ee-66269f8d8b6a@acm.org> Content-Language: en-US From: Palash Kambar In-Reply-To: <97050b9c-7174-4402-a1ee-66269f8d8b6a@acm.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 6wOxJA3HgyNRykIqUQwwuORC_uMOG1Dk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAzMDEwNSBTYWx0ZWRfX6OD5o3M3YNh3 SUmkwwgzK4sd68ilYOoZLo9wQ1SZRzwAdle/1M5Jb+7/GMViBUFml7j+vOrCMcRvy3e3ux3rLu9 66FfdNUh2G7SVCkQ6zWZykvxGIrb9EkU+7SBqiOgWSnlN8swJy3NHg/NdsAR4aeJmd+ITGKReEd j0cZe/V99pEc1ivxN272DXGoBai2Ls5U5mGqVi7FWU8t24yu3hp8rSMQJKOxi3yBKrRdxp4dSis eljuDe7rt/p5gKI1VEv9b2Fvv1g4403fmhHDDJ7UupGBcuyMUe8cwTAXkHyuy7LsIPGsKCSagg6 lUA9zyiwwGC+4FDVcX7AhW51Ilag/OYLMhO4UzjDG7lF/ODutm+2GJhpnO9w4l4SDL0degOYwPn 48O/uydI9Vu+OYKAe9D5C9UVVn7ehbRpXpPYCSwV71BtSCvfIRRkeYpMPGFo8fI9yi30fKHWEkZ nCs3MZumbpgLayLAOBg== X-Authority-Analysis: v=2.4 cv=ZuPg6t7G c=1 sm=1 tr=0 ts=69cfaba3 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=3zKRCnpXH6Dit4Bn3WgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: 6wOxJA3HgyNRykIqUQwwuORC_uMOG1Dk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-03_03,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604030105 On 3/28/2026 2:52 AM, Bart Van Assche wrote: > On 3/27/26 2:03 AM, palash.kambar@oss.qualcomm.com wrote: >> On platforms that support Auto Hibern8 (AH8), the UFS controller can >> autonomously de-assert clk_req signals to the GCC when entering the >> Hibern8 state. This allows GCC to gate unused clocks, improving >> power efficiency. > > What is the "GCC"? Please expand acronyms that are neither defined in > the UFSHCI standard nor in the UFS standard. > >> +static void ufs_qcom_link_startup_post_change(struct ufs_hba *hba) >> +{ >> +    if (ufshcd_is_auto_hibern8_supported(hba)) { >> +        ufshcd_rmwl(hba, UFS_HW_CLK_CTRL_EN, UFS_HW_CLK_CTRL_EN, >> +                UFS_AH8_CFG); >> +    } >> +} > > From the Linux kernel coding style "Do not unnecessarily use braces where a single statement will do." Please follow that rule. > > Thanks, > > Bart. Sure Bart, will address these comments.