From: Vladimir Zapolskiy <vz@mleia.com>
To: Purva Yeshi <purvayeshi550@gmail.com>,
ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, piotr.wojtaszczyk@timesys.com
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: pwm: Convert lpc32xx-pwm.txt to YAML
Date: Wed, 12 Mar 2025 19:59:21 +0200 [thread overview]
Message-ID: <57ae63a2-544b-4241-a54d-8fa9917c1e44@mleia.com> (raw)
In-Reply-To: <20250312122750.6391-1-purvayeshi550@gmail.com>
Hello Purva.
Thank you for your contribution.
On 3/12/25 14:27, Purva Yeshi wrote:
> Convert the existing `lpc32xx-pwm.txt` bindings documentation into a
> YAML schema (`nxp,lpc3220-pwm.yaml`).
>
> Set `"#pwm-cells"` to `const: 3` for expected PWM cell properties.
Actually it shall be set to 1.
>
> Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
> ---
> V1 - https://lore.kernel.org/all/20250311125756.24064-1-purvayeshi550@gmail.com/
> V2 - Correct filename to match the compatible string, remove unnecessary
> quotes in maintainers, and refine commit message.
>
> .../devicetree/bindings/pwm/lpc32xx-pwm.txt | 17 ---------
> .../bindings/pwm/nxp,lpc3220-pwm.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 17 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> create mode 100644 Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
>
> diff --git a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> deleted file mode 100644
> index 74b5bc5dd..000000000
> --- a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -LPC32XX PWM controller
> -
> -Required properties:
> -- compatible: should be "nxp,lpc3220-pwm"
> -- reg: physical base address and length of the controller's registers
> -
> -Examples:
> -
> -pwm@4005c000 {
> - compatible = "nxp,lpc3220-pwm";
> - reg = <0x4005c000 0x4>;
> -};
> -
> -pwm@4005c004 {
> - compatible = "nxp,lpc3220-pwm";
> - reg = <0x4005c004 0x4>;
> -};
> diff --git a/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
> new file mode 100644
> index 000000000..432a5e9d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/nxp,lpc3220-pwm.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/nxp,lpc3220-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LPC32XX PWM controller
> +
> +maintainers:
> + - Vladimir Zapolskiy <vz@mleia.com>
> + - Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>
> +
> +allOf:
> + - $ref: pwm.yaml#
> +
> +properties:
> + compatible:
> + const: nxp,lpc3220-pwm
> +
> + reg:
> + maxItems: 1
> +
> + "#pwm-cells":
> + const: 3
It shall be 1.
> +
> +required:
> + - compatible
> + - reg
> +
There is an error in the original lpc32xx-pwm.txt file, one more property
"clocks" is strictly required, please add it along with the conversion.
Thank you!
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + pwm@4005c000 {
> + compatible = "nxp,lpc3220-pwm";
> + reg = <0x4005c000 0x4>;
> + #pwm-cells = <3>;
> + };
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2025-03-12 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 12:27 Purva Yeshi
2025-03-12 17:59 ` Vladimir Zapolskiy [this message]
2025-03-12 22:56 ` Uwe Kleine-König
2025-03-13 3:37 ` Vladimir Zapolskiy
2025-03-13 7:22 ` Uwe Kleine-König
2025-03-13 11:04 ` Krzysztof Kozlowski
2025-03-13 14:25 ` Purva Yeshi
2025-04-01 17:32 ` Purva Yeshi
2025-04-02 6:33 ` Krzysztof Kozlowski
2025-04-04 19:38 ` Purva Yeshi
2025-04-03 10:41 ` Uwe Kleine-König
2025-04-04 19:42 ` Purva Yeshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57ae63a2-544b-4241-a54d-8fa9917c1e44@mleia.com \
--to=vz@mleia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=purvayeshi550@gmail.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®