From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C53BC433E3 for ; Wed, 19 Aug 2020 12:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 634EA205CB for ; Wed, 19 Aug 2020 12:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597838766; bh=ClOj9yCdunMaS320vDbGtPzjoJaPHr/Jec/oQrO5Wog=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=g6msbS/xNGePiVHVvVbiM9znDGR7eosxO9J6n7yg+DKSIGiParnbi0+l9z1RQyTEQ LTqSFkINhkrUC1BQH3ZwvqY9DuDFltSkMdP0+yU+R9I+JRZ6CjgmQQjP+8AE5EEf5J n3rrqx/A4eXfabYdEo22K1f1IAsPIyfmgwQNQNtU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728138AbgHSMFu (ORCPT ); Wed, 19 Aug 2020 08:05:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:49444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728219AbgHSLrn (ORCPT ); Wed, 19 Aug 2020 07:47:43 -0400 Received: from mail.kernel.org (ip5f5ad5a3.dynamic.kabel-deutschland.de [95.90.213.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1AD122DBF; Wed, 19 Aug 2020 11:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597837582; bh=ClOj9yCdunMaS320vDbGtPzjoJaPHr/Jec/oQrO5Wog=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MVV06K30OMwQxMR9UYLuS5tjtvikFOPCCbBz4lYgjKxawcw5P+FsTnnDYXWE1i8/+ 6nzftgJ4wBkKmytQS2gjlp7HtmvtUtXbXGozU383UCoq/3B6jb6l7izdb9fJEBOriL 73tA7qkvRhsEKDdLU6xURH6vvyIUnDu64g/5SiLw= Received: from mchehab by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1k8MXs-00EubC-Gf; Wed, 19 Aug 2020 13:46:20 +0200 From: Mauro Carvalho Chehab To: Greg Kroah-Hartman Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , John Stultz , Manivannan Sadhasivam , Daniel Vetter , dri-devel , Xiubin Zhang , Liwei Cai , Wanchun Zheng , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 29/49] staging: hikey9xx/gpu: add a possible implementation for atomic_disable Date: Wed, 19 Aug 2020 13:45:57 +0200 Message-Id: <57af4d50a42f4547344ff0a67bcdc4370dbe6d24.1597833138.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, the method is empty. However, looking at the driver, it sounds it shouldn't be hard to implement it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c b/drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c index e1f2557a6be1..26212c130b79 100644 --- a/drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c +++ b/drivers/staging/hikey9xx/gpu/kirin9xx_drm_dss.c @@ -638,7 +638,14 @@ static void dss_plane_atomic_update(struct drm_plane *plane, static void dss_plane_atomic_disable(struct drm_plane *plane, struct drm_plane_state *old_state) { - //struct dss_plane *aplane = to_dss_plane(plane); + // FIXME: Maybe this? +#if 0 + struct dss_plane *aplane = to_dss_plane(plane); + struct dss_crtc *acrtc = aplane->acrtc; + + disable_ldi(acrtc); + hisifb_mctl_sw_clr(acrtc); +#endif } static const struct drm_plane_helper_funcs dss_plane_helper_funcs = { -- 2.26.2