From: Shuah Khan <shuah@kernel.org>
To: Oliver Neukum <oneukum@suse.com>,
Shuah Khan <shuahkh@osg.samsung.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: valentina.manea.m@gmail.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] usbip: vhc_hcd: prevent module being removed while device are attached
Date: Wed, 4 Apr 2018 09:14:06 -0600 [thread overview]
Message-ID: <57af9443-7d2d-c3ff-3da6-0765ea0560f8@kernel.org> (raw)
In-Reply-To: <1522830330.30374.3.camel@suse.com>
On 04/04/2018 02:25 AM, Oliver Neukum wrote:
> Am Dienstag, den 03.04.2018, 09:56 -0600 schrieb Shuah Khan:
>> This is a virtual device associated to a real physical device on a different
>> system. My concern is that if the module gets removed accidentally then it
>> could disrupt access to the remote device. The remote nature of the device
>> with several players involved makes this scenario a bit more complex than
>
> Hi,
>
> you would doubtlessly lose connection to that device. Yet you would
> also lose connections if you down your network. You need to be root
> to unload a module. You could overwrite your root filesystems or flash
> your firmware. In general we cannot and don't try to protect root
> from such accidents.
>
Yes. There are several scenarios that could disrupt access. There are
no bad things happening other than the expected read failures when the
device is actively in use.
thanks for the review.
-- Shuah
prev parent reply other threads:[~2018-04-04 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 20:52 Shuah Khan
2018-04-02 20:52 ` [PATCH] usbip: vhci_hcd: Fix usb device and sockfd leaks Shuah Khan
2018-04-03 6:56 ` Greg KH
2018-04-03 13:54 ` Shuah Khan
2018-04-03 6:56 ` [PATCH] usbip: vhc_hcd: prevent module being removed while device are attached Greg KH
2018-04-03 15:56 ` Shuah Khan
2018-04-04 8:25 ` Oliver Neukum
2018-04-04 15:14 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57af9443-7d2d-c3ff-3da6-0765ea0560f8@kernel.org \
--to=shuah@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=shuahkh@osg.samsung.com \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome