From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
To: Jarkko Sakkinen <jarkko@kernel.org>,
Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, stefanb@linux.vnet.ibm.com,
linux@mniewoehner.de, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org, jandryuk@gmail.com,
pmenzel@molgen.mpg.de, lukas@wunner.de, p.rosenberger@kunbus.com
Subject: Re: [PATCH v8 08/11] tpm, tpm: Implement usage counter for locality
Date: Fri, 4 Nov 2022 17:18:21 +0100 [thread overview]
Message-ID: <57b193a6-8340-c883-04bc-6cfbc3c638cd@kunbus.com> (raw)
In-Reply-To: <Y2Bw/yhTs258Iiew@kernel.org>
On 01.11.22 02:06, Jarkko Sakkinen wrote:
> On Tue, Oct 25, 2022 at 02:15:51AM +0200, Lino Sanfilippo wrote:
>> Actually thats on me, since it took me much too long to send the v8 after the v7 review.
>>
>> However the reason that we need a mutex here is that we not only increase or decrease
>> the locality_counter under the mutex, but also do the locality request and release by
>> writing to the ACCESS register. Since in the SPI case each communication over the spi bus
>> is protected by the bus_lock_mutex of the SPI device we must not hold a spinlock when doing
>> the register accesses.
>>
>> Concerning covering the whole tpm_tis_data struct:
>> Most structure elements are set once at driver startup but never changed at driver
>> runtime. So no locking needed for these. The only exception is "flags" and "locality_count"
>> whereby "flags" is accessed by atomic bit manipulating functions and thus
>> does not need extra locking. So "locality_count" is AFAICS the only element that needs to be
>> protected by the mutex.
>
> OK, but you should should still address this in commit message, e.g.
> by mentioning that in the case of SPI bus mutex is required because
> the bus itself needs to be locked in the mutex.
>
> I.e. this a claim, definitely not an argument: "Ensure thread-safety by
> protecting the counter with a mutex."
>
Ok, I will rephrase the commit message accordingly.
Thanks for the review!
Regards,
Lino
next prev parent reply other threads:[~2022-11-04 16:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 23:57 [PATCH v8 00/11] TPM IRQ fixes Lino Sanfilippo
2022-10-17 23:57 ` [PATCH v8 01/11] tpm, tpm_tis: Avoid cache incoherency in test for interrupts Lino Sanfilippo
2022-10-17 23:57 ` [PATCH v8 02/11] tpm, tpm_tis: Claim locality before writing TPM_INT_ENABLE register Lino Sanfilippo
2022-10-17 23:57 ` [PATCH v8 03/11] tpm, tpm_tis: Disable interrupts if tpm_tis_probe_irq() failed Lino Sanfilippo
2022-10-17 23:57 ` [PATCH v8 04/11] tpm, tmp_tis: Claim locality before writing interrupt registers Lino Sanfilippo
2022-10-17 23:57 ` [PATCH v8 05/11] tpm, tpm_tis: Only handle supported interrupts Lino Sanfilippo
2022-10-17 23:57 ` [PATCH v8 06/11] tpm, tpm_tis: Move interrupt mask checks into own function Lino Sanfilippo
2022-10-17 23:57 ` [PATCH v8 07/11] tpm, tpm_tis: do not check for the active locality in interrupt handler Lino Sanfilippo
2022-10-23 4:32 ` Jarkko Sakkinen
2022-10-17 23:57 ` [PATCH v8 08/11] tpm, tpm: Implement usage counter for locality Lino Sanfilippo
2022-10-18 6:25 ` Lukas Wunner
2022-10-18 7:42 ` Lino Sanfilippo
2022-10-23 5:26 ` Jarkko Sakkinen
2022-10-25 0:25 ` Lino Sanfilippo
2022-11-01 1:06 ` Jarkko Sakkinen
2022-10-23 4:40 ` Jarkko Sakkinen
2022-10-25 0:15 ` Lino Sanfilippo
2022-11-01 1:06 ` Jarkko Sakkinen
2022-11-04 16:18 ` Lino Sanfilippo [this message]
2022-11-07 16:03 ` Jarkko Sakkinen
2022-10-17 23:57 ` [PATCH v8 09/11] tpm, tpm_tis: Request threaded interrupt handler Lino Sanfilippo
2022-10-17 23:57 ` [PATCH v8 10/11] tpm, tpm_tis: Claim locality in " Lino Sanfilippo
2022-10-17 23:57 ` [PATCH v8 11/11] tpm, tpm_tis: Enable interrupt test Lino Sanfilippo
2022-10-23 4:33 ` Jarkko Sakkinen
2022-10-23 4:34 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57b193a6-8340-c883-04bc-6cfbc3c638cd@kunbus.com \
--to=l.sanfilippo@kunbus.com \
--cc=LinoSanfilippo@gmx.de \
--cc=jandryuk@gmail.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@mniewoehner.de \
--cc=lukas@wunner.de \
--cc=p.rosenberger@kunbus.com \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®