mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Zhang Bo" <zbsdta@126.com>
To: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Cc: paolo.valente@unimore.it, axboe@kernel.dk
Subject: bfq io scheduler fifo_expire_sync have no function
Date: Wed, 19 Jul 2023 21:35:47 +0800 (CST)	[thread overview]
Message-ID: <57b197f2.440d.1896e5d2c48.Coremail.zbsdta@126.com> (raw)

In bfq_check_fifo(...) function,  bfq_bfqq_fifo_expire(bfqq) is checked at first, and then  bfq_mark_bfqq_fifo_expire(bfqq) later. 
I think bfq_check_fifo return NULL because of bfq_bfqq_fifo_expire(bfqq) return true. So expired request is not dispatch.
Could any one explain this problem?

static struct request *bfq_check_fifo(struct bfq_queue *bfqq,
				      struct request *last)
{
	struct request *rq;

	if (bfq_bfqq_fifo_expire(bfqq)) {
		return NULL;
	}

	bfq_mark_bfqq_fifo_expire(bfqq);

	...................
}

                 reply	other threads:[~2023-07-19 13:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57b197f2.440d.1896e5d2c48.Coremail.zbsdta@126.com \
    --to=zbsdta@126.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.valente@unimore.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome