From: Guenter Roeck <linux@roeck-us.net>
To: Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>
Cc: alice.guo@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
s.hauer@pengutronix.de, shawnguo@kernel.org,
wim@linux-watchdog.org, ye.li@nxp.com
Subject: Re: [PATCH v3 1/1] watchdog: imx7ulp_wdt: move post_rcs_wait into struct imx_wdt_hw_feature
Date: Mon, 15 Jul 2024 11:01:57 -0700 [thread overview]
Message-ID: <57b1d9da-ea7a-4df8-bc02-a3c9db4f28da@roeck-us.net> (raw)
In-Reply-To: <CAOMZO5AqX25zduLXfXq6zU4SLRC_zs6ZU_D7ouA70iCdp-bt_g@mail.gmail.com>
On 7/15/24 10:16, Fabio Estevam wrote:
> Hi Frank,
>
> On Mon, Jul 15, 2024 at 2:07 PM Frank Li <Frank.Li@nxp.com> wrote:
>>
>> Move post_rcs_wait into struct imx_wdt_hw_feature to simplify code logic
>> for different compatible strings
>>
>> i.MX93 and i.MX8ULP watchdog do not need to wait 2.5 clocks after RCS is
>> done. Set post_rcs_wait to false explicitly to maintain code consistency.
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>> Signed-off-by: Alice Guo <alice.guo@nxp.com>
>> Reviewed-by: Ye Li <ye.li@nxp.com>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>
> It looks better now, thanks:
>
Not in my opinion. As requested in my other e-mail, please drop my Reviewed-by: tag.
Guenter
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
next prev parent reply other threads:[~2024-07-15 18:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 17:07 Frank Li
2024-07-15 17:16 ` Fabio Estevam
2024-07-15 18:01 ` Guenter Roeck [this message]
2024-07-15 18:01 ` Guenter Roeck
2024-07-15 18:34 ` Frank Li
2024-07-15 21:42 ` Guenter Roeck
2024-07-15 21:56 ` Frank Li
2024-07-16 0:25 ` Guenter Roeck
2024-07-15 21:44 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57b1d9da-ea7a-4df8-bc02-a3c9db4f28da@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Frank.Li@nxp.com \
--cc=alice.guo@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®