From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 994FB81AB1 for ; Tue, 23 Jan 2024 16:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706028744; cv=none; b=PsKxj0WDUMvK86wBSGICIBJeQ1roZIYJ3rcuG05+g/vG9YsEI7qc4jbz7aZ2q43EIWaueCbCINbyYwu3iqkCzIt6fB8AF1JZi8C/EY/JH+eFzhdt756IdgkF2nNxEZrOxHZc76fmsVeONSjU8M0eMe04QrU/3ad44a9vYaLgbgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706028744; c=relaxed/simple; bh=FqxuIhOKwqFFkvdg6FWTdDc61t6BPsqD82lPrYLR5iY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X9qywjdD83avqX6EE6jRC96HwQ8LYHGoqEIAWZ57mSBRPaRmFuB0OHOgr4P7mS8SC1JstzwPH1q6TXYxRD7ZpWkz82KHD1ag4RHXMo7wqNu4f3gP3NXxNRkz551uKICY1LsYxX6fQE/wPx1HQhL5Om0MSI2pZ58Mq99L5oddPBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=8devices.com; spf=pass smtp.mailfrom=8devices.com; dkim=pass (2048-bit key) header.d=8devices.com header.i=@8devices.com header.b=Y1qzR435; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=8devices.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=8devices.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=8devices.com header.i=@8devices.com header.b="Y1qzR435" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-50e9e5c97e1so5686443e87.0 for ; Tue, 23 Jan 2024 08:52:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=8devices.com; s=8devices; t=1706028740; x=1706633540; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kXm+8B2oUV6NHB3wV69TO5cqSgcr9Tcvgdp6j8iimmU=; b=Y1qzR4359Eotry6fI+O0r3gbmmP+2AJmM4h2QMFt/spL+8ESbhDRl9uI4UZVH+qfQe 3nTXfEBYZy0XKBiMhnEpERKpCGO27GDF2wceo/9RE8FHA20FQBZGVKy1dTJJejeLC/gM IN01G135vUgcqE+QK7z2KDfjBAxu7jbFubl4WtpsbDPEG/6WjuYfxnVytGxotJp+zDi6 8P7eXNVcyhgwDDOktbP9tyWak6Dn3D+Fg1bHbyrn2BmcyLEZSkqPLZJmoHFSG3tKr8h/ bnNL+0GsQC66gqmRQ0elt0jf2p8orllYn4qRC015xUgfwZXi1AMpZpuEWTA7vnE3774i /OxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706028740; x=1706633540; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kXm+8B2oUV6NHB3wV69TO5cqSgcr9Tcvgdp6j8iimmU=; b=FJ6FYYbjUxOqA/f5Wz355KCI/DkLdOjd7RleoOEsSloTbShP4adqAVVPxWGcztjWSx UpFTpsH8CcqDe+0ekuDT0Ko4IavLRlk74fpsqEJ0H6nrMpeWcPjJVZzvrsoe1MHZnzKq k+sbNFCF+2IruyGkp1suHg8+OnGZODfCZswxL0U14PNQnm+08aAo/090zTOq/pFswME6 WJUFfzvKjePK3FtkEyD9ocKcCuW0mGllCvgbFR5D/HhsXfaeX19/ExOwb8AuqWjadzQN XLkY4ld0JL0L7zuR7gY/zyqHAZldyfbwZ5pE8XM39Ww+du7CX5yk5MqNiC1jpZTxhquZ +R+g== X-Gm-Message-State: AOJu0YxCGIEgrPsg8sOeD6FQaWlWf8yLltB/iYpAf6rggSyVYdc7rMSF sXFDBeI8PRGV0fnJeXjGgFHS17++ZWLOaGPI5h/7vIpQYhqsTxKZgRfkwYZJpG0= X-Google-Smtp-Source: AGHT+IEChfJWs7cJSnwDKWXR/KKorWCddOvN+gTAgT9MMdF8s9TVHEO/yl02oBF4vRBhKurbwB9fIg== X-Received: by 2002:a05:6512:3050:b0:50e:30a8:4c8e with SMTP id b16-20020a056512305000b0050e30a84c8emr3204334lfb.43.1706028740692; Tue, 23 Jan 2024 08:52:20 -0800 (PST) Received: from [192.168.2.155] (78-62-132-154.static.zebra.lt. [78.62.132.154]) by smtp.gmail.com with ESMTPSA id g21-20020a19e055000000b0050e94329e7csm2407169lfj.269.2024.01.23.08.52.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jan 2024 08:52:20 -0800 (PST) Message-ID: <57b3be8b-0953-4686-b370-6d395b8124ff@8devices.com> Date: Tue, 23 Jan 2024 18:52:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] phy: qcom-qmp-usb: fix register offsets for ipq8074/ipq6018 Content-Language: en-US To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <1706026160-17520-1-git-send-email-mantas@8devices.com> <1706026160-17520-2-git-send-email-mantas@8devices.com> From: Mantas In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-01-23 18:42, Dmitry Baryshkov wrote: > On Tue, 23 Jan 2024 at 18:09, Mantas Pucka wrote: >> Commit 2be22aae6b18 ("phy: qcom-qmp-usb: populate offsets configuration") >> introduced register offsets to the driver but for ipq8074/ipq6018 they do >> not match what was in the old style device tree. Example from old >> ipq6018.dtsi: >> >> <0x00078200 0x130>, /* Tx */ >> <0x00078400 0x200>, /* Rx */ >> <0x00078800 0x1f8>, /* PCS */ >> <0x00078600 0x044>; /* PCS misc */ >> >> which would translate to: >> {.., .pcs = 0x800, .pcs_misc = 0x600, .tx = 0x200, .rx = 0x400 } >> >> but was translated to: >> {.., .pcs = 0x600, .tx = 0x200, .rx = 0x400 } > Even worse, it was translated to { ... .pcs = 0xc00, .pcs_misc = 0xa00 ... } I was referring to qmp_usb_offsets_v3 here as ipq8074/ipq6018 did use them, not qmp_usb_offsets_v3_qcm2290. > > With this fixed: > > Reviewed-by: Dmitry Baryshkov > >> So split usb_offsets and fix USB initialization for IPQ8074 and IPQ6018. >> Tested only on IPQ6018 >> >> Fixes: 2be22aae6b18 ("phy: qcom-qmp-usb: populate offsets configuration") >> Signed-off-by: Mantas Pucka >> --- >> drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >