From: Daniel Borkmann <daniel@iogearbox.net>
To: Sean Young <sean@mess.org>, Y Song <ys114321@gmail.com>,
Matthias Reichl <hias@horus.com>,
linux-media@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
netdev <netdev@vger.kernel.org>,
Devin Heitmueller <dheitmueller@kernellabs.com>,
Quentin Monnet <quentin.monnet@netronome.com>
Subject: Re: [PATCH v4] bpf: attach type BPF_LIRC_MODE2 should not depend on CONFIG_CGROUP_BPF
Date: Tue, 26 Jun 2018 12:03:35 +0200 [thread overview]
Message-ID: <57baf751-cd2a-dedf-05bc-9ac3b4e050be@iogearbox.net> (raw)
In-Reply-To: <20180618230423.nk2ey2755p2zkqmv@gofer.mess.org>
On 06/19/2018 01:04 AM, Sean Young wrote:
> If the kernel is compiled with CONFIG_CGROUP_BPF not enabled, it is not
> possible to attach, detach or query IR BPF programs to /dev/lircN devices,
> making them impossible to use. For embedded devices, it should be possible
> to use IR decoding without cgroups or CONFIG_CGROUP_BPF enabled.
>
> This change requires some refactoring, since bpf_prog_{attach,detach,query}
> functions are now always compiled, but their code paths for cgroups need
> moving out. Rather than a #ifdef CONFIG_CGROUP_BPF in kernel/bpf/syscall.c,
> moving them to kernel/bpf/cgroup.c and kernel/bpf/sockmap.c does not
> require #ifdefs since that is already conditionally compiled.
>
> Signed-off-by: Sean Young <sean@mess.org>
Applied to bpf, thanks Sean!
next prev parent reply other threads:[~2018-06-26 10:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-27 11:24 [PATCH v5 0/3] IR decoding using BPF Sean Young
2018-05-27 11:24 ` [PATCH v5 1/3] bpf: bpf_prog_array_copy() should return -ENOENT if exclude_prog not found Sean Young
2018-05-27 11:24 ` [PATCH v5 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2 Sean Young
2018-06-04 17:47 ` Matthias Reichl
2018-06-05 10:16 ` Sean Young
2018-06-05 10:33 ` Daniel Borkmann
2018-06-06 21:09 ` [PATCH] bpf: attach type BPF_LIRC_MODE2 should not depend on CONFIG_BPF_CGROUP Sean Young
2018-06-07 18:12 ` Simon Horman
2018-06-07 18:14 ` Y Song
2018-06-07 22:40 ` Daniel Borkmann
2018-06-14 18:42 ` [PATCH] bpf: attach type BPF_LIRC_MODE2 should not depend on CONFIG_CGROUP_BPF Sean Young
2018-06-15 14:03 ` Daniel Borkmann
2018-06-18 17:12 ` [PATCH v3] " Sean Young
2018-06-18 18:46 ` kbuild test robot
2018-06-18 22:56 ` Sean Young
2018-06-18 23:04 ` [PATCH v4] " Sean Young
2018-06-26 10:03 ` Daniel Borkmann [this message]
2018-05-27 11:24 ` [PATCH v5 3/3] bpf: add selftest for lirc_mode2 type program Sean Young
2018-05-30 10:57 ` [PATCH v5 0/3] IR decoding using BPF Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57baf751-cd2a-dedf-05bc-9ac3b4e050be@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=dheitmueller@kernellabs.com \
--cc=hias@horus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
--cc=sean@mess.org \
--cc=ys114321@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®