From: Thomas Antoine <t.antoine@uclouvain.be>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Rob Herring" <robh@kernel.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Dimitri Fedrau" <dima.fedrau@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 3/5] dt-bindings: power: supply: add max77759-fg flavor
Date: Wed, 23 Apr 2025 10:05:42 +0200 [thread overview]
Message-ID: <57bb1dfd-02dd-4aa4-a560-264875ded33c@uclouvain.be> (raw)
In-Reply-To: <20250422-tireless-swine-of-fascination-6eba8b@kuoka>
On 4/22/25 12:05, Krzysztof Kozlowski wrote:
> On Mon, Apr 21, 2025 at 08:13:34PM GMT, Thomas Antoine wrote:
>> +allOf:
>> + - $ref: power-supply.yaml#
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - maxim,max17201
>> + then:
>> + properties:
>> + reg:
>> + minItems: 2
>> + maxItems: 2
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - maxim,max77759-fg
>> + then:
>> + properties:
>> + reg:
>> + items:
>> + minItems: 1
> If there is going to be resend, drop minItems.
>
Will drop it in v4.
>> + maxItems: 1
>> + shunt-resistor-micro-ohms:
>> + description: The value of current sense resistor in microohms.
> Property should be defined top-level list of properties and in other
> variant if:then: you disallow it if it is not applicable at all
> (shunt-resistor-micro-ohms: false).
>
Will change in v4.
> Best regards,
> Krzysztof
>
Best regards,
Thomas Antoine
next prev parent reply other threads:[~2025-04-23 8:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 18:13 [PATCH v3 0/5] Google Pixel 6 (oriole): max77759 fuel gauge enablement and driver support Thomas Antoine via B4 Relay
2025-04-21 18:13 ` [PATCH v3 1/5] power: supply: correct capacity computation Thomas Antoine via B4 Relay
2025-04-22 9:46 ` Dimitri Fedrau
2025-04-23 7:48 ` Thomas Antoine
2025-04-21 18:13 ` [PATCH v3 2/5] power: supply: add support for max77759 fuel gauge Thomas Antoine via B4 Relay
2025-04-22 18:48 ` Dimitri Fedrau
2025-04-23 8:02 ` Thomas Antoine
2025-04-30 0:36 ` Sebastian Reichel
2025-04-30 13:49 ` Thomas Antoine
2025-04-21 18:13 ` [PATCH v3 3/5] dt-bindings: power: supply: add max77759-fg flavor Thomas Antoine via B4 Relay
2025-04-22 10:05 ` Krzysztof Kozlowski
2025-04-23 8:05 ` Thomas Antoine [this message]
2025-04-23 13:45 ` Krzysztof Kozlowski
2025-04-30 13:51 ` Thomas Antoine
2025-04-21 18:13 ` [PATCH v3 4/5] arm64: defconfig: enable Maxim max1720x driver Thomas Antoine via B4 Relay
2025-04-21 18:13 ` [PATCH v3 5/5] arm64: dts: exynos: gs101-oriole: enable Maxim max77759 fuel gauge Thomas Antoine via B4 Relay
2025-04-21 21:53 ` [PATCH v3 0/5] Google Pixel 6 (oriole): max77759 fuel gauge enablement and driver support Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57bb1dfd-02dd-4aa4-a560-264875ded33c@uclouvain.be \
--to=t.antoine@uclouvain.be \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®