From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C1ECC83004 for ; Tue, 28 Apr 2020 11:45:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AC65206D7 for ; Tue, 28 Apr 2020 11:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbgD1LpF (ORCPT ); Tue, 28 Apr 2020 07:45:05 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3324 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726285AbgD1LpE (ORCPT ); Tue, 28 Apr 2020 07:45:04 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id ED5169C0DE979926EC9A; Tue, 28 Apr 2020 19:44:59 +0800 (CST) Received: from [127.0.0.1] (10.166.213.7) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Tue, 28 Apr 2020 19:44:50 +0800 Subject: Re: [PATCH] pinctrl: remove unused 'pwm37_pins' To: Manivannan Sadhasivam , Linus Walleij CC: Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Hulk Robot References: <20200417092112.12303-1-yanaijie@huawei.com> <20200428113049.GA5259@Mani-XPS-13-9360> From: Jason Yan Message-ID: <57bc1105-06e9-2951-45c0-04b048f65d2e@huawei.com> Date: Tue, 28 Apr 2020 19:44:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200428113049.GA5259@Mani-XPS-13-9360> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.166.213.7] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/4/28 19:30, Manivannan Sadhasivam 写道: > On Tue, Apr 28, 2020 at 11:58:01AM +0200, Linus Walleij wrote: >> On Fri, Apr 17, 2020 at 10:54 AM Jason Yan wrote: >> >>> Fix the following gcc warning: >>> >>> drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined >>> but not used [-Wunused-const-variable=] >>> static const unsigned int pwm37_pins[] = { 110 }; >>> ^~~~~~~~~~ >>> >>> Reported-by: Hulk Robot >>> Signed-off-by: Jason Yan >> >> I'm sceptic about this. I think PWM37 exists and just need to be >> properly defined. >> >> Mani will know the right solution to this. >> > > Sorry for missing this thread before. The original patch didn't land in my > inbox. > > Anyway the issue is, pwm37 is not added to BM1880_PINCTRL_GRP. So the proper > fix would be to add it. > > Jason, will you be able to send a patch for adding it? Otherwise I'll do that. > OK, I will send v2 soon. Thanks, Jason > Thanks, > Mani > >> Yours, >> Linus Walleij >