From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610CF367F26 for ; Thu, 21 May 2026 08:45:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779353155; cv=none; b=C6pxfJ/yRn+klyPAeIfDzBL0aecVC4A9EnRi3w71+1LGm1tKE2+pDZQeDMoZgy4T42wkV+LwOgwTRWbcpwikxARrn3W40qx5yveV50/g+w0JFXNnam1c5FwM35vql98WLuvGcT1NCygE9zB7CBCYV1vdgvV6ulfSW6YzKnBusjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779353155; c=relaxed/simple; bh=LI1P7U0gaKVb0FmucV8auUmJuUJiOS5F8FS12dF2UIM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sxsIv4xtEefJr7fehsiTCLrfxcYHiP8zSlhiFrdGuBGHd3dzzFIYDS0niKfTOfy7ZZzJnt6ondsXtYhhKBVtvjtkrq8c476CiBukR6dOLuL6WlLUE/e0OlMbRmY+9NtA2Ch1/KeT6FoNG5FWtPQGIuX2EF7olWfQtC6rV6gshAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KpoblIp4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Dfk8qgv5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KpoblIp4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Dfk8qgv5" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L6uhGw963957 for ; Thu, 21 May 2026 08:45:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wJVdsUyX98YGeW/ulFXwxng+OTO4Vq5zgb/1dD/SbDM=; b=KpoblIp4FrCA7WaY V0aY174JYcUU4bEHOb41Z1Bp0vTX6wVHCNGVSD6LkHlJOKSlEM6pMyCchKMWcI+L /FNSpJpvJrPYTW2QcASurlNney0kg8k3i4HM1a1ehtm/ckxjrfjUZ/mbYitG93PW kTikwmzGWt0vQk0lL5Iq2AfhfxwguQDqEW8AwlkY7H8eBD54eQeleAGYZ6Oajzp7 fyfzICeTNV+SCEiVwa+7W66AbpOAarA+WaB8kVMgt+Gk9mFFDoZl75iHWCWO4oid dva7CrlwIQtw7Q9S3DmKdpxHHYzFeXEni4Cv/aP+L0g+zR5bblIqcxaYUFqGvfx/ g+VS4w== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ejh3xpd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 08:45:53 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36642d2f4deso12474965a91.3 for ; Thu, 21 May 2026 01:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779353152; x=1779957952; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wJVdsUyX98YGeW/ulFXwxng+OTO4Vq5zgb/1dD/SbDM=; b=Dfk8qgv5hpROW86sINUAEQxJgcT+F4cvcIbOhO2ceBzhMK419m283sHyNIGASV3mqp 1R1GOTm+OkDvS/an8UYLT4WLvLoDMbJeYn+Z/ncpSX5KenDGG+2TzUT0FqCMRcR3LsiS mKiAx0t/ybQkaGawAZryW/Aanwt390ElyMWdoa/DYEy94jZ+qBKIef3Met1QXy5L3EQ0 97fySqxRl5ETCyUkwDUdprqhNRj0m7xzavUmIxCMM1bTwvIjA8uNnqRR1U4ZQBANrDpe ND79gjiVUzEibOX0pLHvUUtNs7WhcdAQmVx3Dzht4cI6DjFZMP5wbSrXXfjAaDFOJ7Fx z1ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779353152; x=1779957952; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wJVdsUyX98YGeW/ulFXwxng+OTO4Vq5zgb/1dD/SbDM=; b=ILePJQ5PZ1H/0h+4s8qYlLey8kXAt+56/x/jdUpnnqy45Rnnhj7E7PGsYrMnaFxSMu gZ1gTnPP1KrONcj/25sfy9gPOVguEdYfHVmQzqmTjUKlwbBjug7KcVCm7Xqu4j258SrZ 98pE6/Dj22qviRvR7bmOcWPbHOOPbHp5fai9T8h5/1090oXgVO5PInZLIzwI9JNg/qFH uqvrVKo/r2ypPSCDNoemmdp118jnjbLx2svTyek8PsvQ0bt5Diu/5MApP8H8c9AoxCFH P50x75iFUaem/6x6/G8J/YVHY+nvndY98xSNuwcheVV7nNpcPZ9JseMDd/rEfs+mf0vO f9YQ== X-Forwarded-Encrypted: i=1; AFNElJ9sMrtUf898nWiyaQkBFUjtt+pBpj2xim1BVP1aLzcsZBIsO5vLPh82UE6AkQFILMH1CQYS5MBctyhgtA8=@vger.kernel.org X-Gm-Message-State: AOJu0YyJMU8IjyrkSHbAPwabfuubIvMaJ+qSGjU6PqLTQiHGypfo619+ yW/acxzN5KYHrxC7JOd9UAJavxBEGTgUuZ++Gqw/sTUCPZ/erqrIE68XjFU5WFUUk3QdAf9rQWQ FKWswGkAUUeKzprwxL/sPio0IG5GYsQNfpxrUIQ0wOOqpWIS9GjyLZ6jFTj1Cs8sMtj5IXImdw7 8= X-Gm-Gg: Acq92OGJsIF4xEI44/xCU+O2bgn8yc1w1n3Ic1AbRGtU23T8ZVV3oWHmyR3TMIs2hFG mkW3MYXZ9qIvtWYqc+k4rn+2+8dvOYJDImolqeV8PwoI8l3bPiasKXWYL6d9oRG4gY9kwC6iO8G gGXHT6+I4wgw1U2fAxayRwI4uWyr6ZQIUmS3Mz3PvoqUAlnOwmI1hdxjMwJ4niuKQ54Oy53t5MO FfgRROZuogUiJDLWOXrx83Oeg1EZgCnRgWrjL/S2S49V+lDMC5mvGd5BGVNzlrv9mnCWzWQfkNm r54bjIO2UH4CwCnFJ6k1ZgAXNdzX5F5byr6VUIyfDrcIfT/ZgzNxnF9GiAiXimfRJheBc/sRFsb f0BdwANtt39tTH0qMQufg6pRPvpekS2BxioE5JVb22ssejsFVHxLu X-Received: by 2002:a17:90b:2708:b0:35c:30a8:330 with SMTP id 98e67ed59e1d1-36a43887a55mr2172283a91.0.1779353152310; Thu, 21 May 2026 01:45:52 -0700 (PDT) X-Received: by 2002:a17:90b:2708:b0:35c:30a8:330 with SMTP id 98e67ed59e1d1-36a43887a55mr2172239a91.0.1779353151814; Thu, 21 May 2026 01:45:51 -0700 (PDT) Received: from [10.217.222.91] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a46d53ea1sm723782a91.4.2026.05.21.01.45.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 01:45:51 -0700 (PDT) Message-ID: <57c26520-42dd-4159-bd2a-69874945cbbe@oss.qualcomm.com> Date: Thu, 21 May 2026 14:15:45 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: shikra: Add qcrypto node support To: Konrad Dybcio , Thara Gopinath , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Frank Li , Andy Gross Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org References: <20260515-shikra_qcrypto-v1-0-80f07b345c29@oss.qualcomm.com> <20260515-shikra_qcrypto-v1-3-80f07b345c29@oss.qualcomm.com> <8dfa0670-7605-497b-9d53-db9b4a8a3d8d@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <8dfa0670-7605-497b-9d53-db9b4a8a3d8d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=QptuG1yd c=1 sm=1 tr=0 ts=6a0ec641 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=FZn51bsQql4VyS6HqkQA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA4NSBTYWx0ZWRfX2wA6TOa1x6kA JvzBvEyVnULHfLwSuwevsWopDZ8FwgiiXDs1OnYaqz4euwJZBTQa4CXTXGJ+EbeTAtExg1hqfDR 94fPB6kz8C6WcMrOQC2wpOatMZEznmPs+6yQxbYR6KXdaR6BoDbU1Nap7jq4AULXDe/BDVOb3Uk pks/gVI2PNL9KPrv95MbxkFb2ufDrJh8ifB+81bu8XgQiQO5bVKumELPsZVHKnDRu/bDZ2/2qzc StwlY08arp9AYxs8Xgk49v1QV28R80iwCdlf9dvx65q30b4FzTDPI3wjcH5E9Uo1jLi2jEX3try yHjmbnvoWL4XyvcgTtBCHO0P2REUgxODx1XySoElsPr94KTCFSGps7y9H6d6DZVhIYkeU2LEEUF TnR8mQCKyKgAYY2cbNgUbmppi6yYJvz0d338Vf5I+AtXp9kdZz18+OdvANnxsML8TYHYF2Z8j62 OvD5ukX2+U0sa491ENA== X-Proofpoint-GUID: XDJoND-L3Lp9a7gBiXQzipXFLC3AcTjB X-Proofpoint-ORIG-GUID: XDJoND-L3Lp9a7gBiXQzipXFLC3AcTjB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210085 On 15-05-2026 15:58, Konrad Dybcio wrote: > On 5/14/26 9:23 PM, Kuldeep Singh wrote: >> Add qcrypto and cryptobam support for shikra target. >> >> Signed-off-by: Kuldeep Singh >> --- >> arch/arm64/boot/dts/qcom/shikra.dtsi | 35 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi >> index 262c488add1e..dbac0e901d6e 100644 >> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi >> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi >> @@ -541,6 +541,41 @@ config_noc: interconnect@1900000 { >> #interconnect-cells = <2>; >> }; >> >> + cryptobam: dma-controller@1b04000 { >> + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; >> + reg = <0x0 0x01b04000 0x0 0x24000>; >> + interrupts = ; >> + #dma-cells = <1>; >> + iommus = <&apps_smmu 0x84 0x0011>, >> + <&apps_smmu 0x86 0x0011>, >> + <&apps_smmu 0x92 0x0>, > >> + <&apps_smmu 0x94 0x0011>, >> + <&apps_smmu 0x96 0x0011>, > > These two entries are logically the same (SID & ~mask) as the first two, > does it still work if you remove them? Yes, resulting sid is same for 84/94 and 86/92. Basically, the resulting sid could be same, it's an optimization which smmu is doing which can result in same SMR(Stream matching register) routing 2 different sid to same context bank. So, 2 sid can be used even though resulting sid remains same. Also, DT usually dictates what hw capabilities are supported and hence, captured all apps entries here to match the hardware description. I hope this answers your query. > > >> + <&apps_smmu 0x98 0x0001>, >> + <&apps_smmu 0x9F 0x0>; > > Let's keep lowercase hex Sure, will update in next rev. Please note, I'll be clubbing patches together in one series as suggested by krzysztof and fix this too that time. -- Regards Kuldeep