Re: [PATCH v2 6/6] spi: cadence-xspi: Add workaround for old Marvell firmwares

[Paul Cercueil <paul.cercueil@bootlin.com>]

I had missed the big fat "#ifdef CONFIG_ACPI" in linux/acpi.h.

Looks like some structs aren't defined if !CONFIG_ACPI. Not great design IMHO.

I guess I'll send a v3 with ifdef guards around the ACPI code...

Cheers,
-Paul

Le jeudi 12 novembre 2026 à 20:02 +0800, kernel test robot a écrit :
> Hi Paul,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on broonie-spi/for-next]
> [also build test ERROR on linus/master v7.4-rc2 next-20261110]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:   
> https://github.com/intel-lab-lkp/linux/commits/Paul-Cercueil/spi-cadence-xspi-Properly-handle-errors-in-transfer_one_message/20261111-113536
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-
> next
> patch link:   
> https://lore.kernel.org/r/20261111103541.100848-7-paul.cercueil%40bootlin.com
> patch subject: [PATCH v2 6/6] spi: cadence-xspi: Add workaround for old
> Marvell firmwares
> config: sparc64-allmodconfig
> (https://download.01.org/0day-ci/archive/20261112/202611121914.Tdw8zp6W-lkp@in
> tel.com/config)
> compiler: clang version 20.1.8
> (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261
> )
> reproduce (this is a W=1 build):
> (https://download.01.org/0day-ci/archive/20261112/202611121914.Tdw8zp6W-lkp@in
> tel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version
> of
> the same patch/commit), kindly add following tags
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202611121914.Tdw8zp6W-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> > > drivers/spi/spi-cadence-xspi.c:1234:58: error: array has incomplete
> > > element type 'const struct acpi_platform_list'
>     1234 | static const struct acpi_platform_list mrvl_platform_list[] = {
>          |                                                          ^
>    drivers/spi/spi-cadence-xspi.c:1234:21: note: forward declaration of
> 'struct acpi_platform_list'
>     1234 | static const struct acpi_platform_list mrvl_platform_list[] = {
>          |                     ^
> > > drivers/spi/spi-cadence-xspi.c:1239:11: error: use of undeclared
> > > identifier 'all_versions'
>     1239 |                 .pred = all_versions,
>          |                         ^
> > > drivers/spi/spi-cadence-xspi.c:1249:10: error: call to undeclared function
> > > 'acpi_match_platform_list'; ISO C99 and later do not support implicit
> > > function declarations [-Wimplicit-function-declaration]
>     1249 |                 return acpi_match_platform_list(mrvl_platform_list)
> >= 0;
>          |                        ^
>    3 errors generated.
> 
> 
> vim +1234 drivers/spi/spi-cadence-xspi.c
> 
>   1233	
> > 1234	static const struct acpi_platform_list mrvl_platform_list[] = {
>   1235		{
>   1236			.oem_id = "MRVL  ",
>   1237			.oem_table_id = "CN10K",
>   1238			.table = ACPI_SIG_DSDT,
> > 1239			.pred = all_versions,
>   1240		},
>   1241		{ }
>   1242	};
>   1243	
>   1244	static inline bool cdns_is_marvell(struct device *dev)
>   1245	{
>   1246		const char *compatible;
>   1247	
>   1248		if (has_acpi_companion(dev))
> > 1249			return acpi_match_platform_list(mrvl_platform_list)
> > >= 0;
>   1250	
>   1251		if (of_machine_read_compatible(&compatible, 0) < 0)
>   1252			return false; /* shouldn't actually happen */
>   1253	
>   1254		return strstarts(compatible, "marvell,");
>   1255	}
>   1256	
> 
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki