mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shannon Nelson <snelson@pensando.io>
To: Arnd Bergmann <arnd@arndb.de>,
	Pensando Drivers <drivers@pensando.io>,
	"David S. Miller" <davem@davemloft.net>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Leon Romanovsky <leon@kernel.org>,
	Kalle Valo <kvalo@codeaurora.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ionic: select CONFIG_NET_DEVLINK
Date: Tue, 1 Oct 2019 09:01:43 -0700	[thread overview]
Message-ID: <57c673d8-a1f2-e759-7a7d-3cbf9b370d55@pensando.io> (raw)
In-Reply-To: <20191001142151.1206987-1-arnd@arndb.de>

On 10/1/19 7:21 AM, Arnd Bergmann wrote:
> When no other driver selects the devlink library code, ionic
> produces a link failure:
>
> drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc':
> ionic_devlink.c:(.text+0xd): undefined reference to `devlink_alloc'
> drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_register':
> ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register'
>
> Add the same 'select' statement that the other drivers use here.
>
> Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/net/ethernet/pensando/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig
> index bd0583e409df..d25b88f53de4 100644
> --- a/drivers/net/ethernet/pensando/Kconfig
> +++ b/drivers/net/ethernet/pensando/Kconfig
> @@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO
>   config IONIC
>   	tristate "Pensando Ethernet IONIC Support"
>   	depends on 64BIT && PCI
> +	select NET_DEVLINK
>   	help
>   	  This enables the support for the Pensando family of Ethernet
>   	  adapters.  More specific information on this driver can be

Thanks!

Acked-by: Shannon Nelson <snelson@pensando.io>


  reply	other threads:[~2019-10-01 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01 14:21 Arnd Bergmann
2019-10-01 16:01 ` Shannon Nelson [this message]
2019-10-01 16:24 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57c673d8-a1f2-e759-7a7d-3cbf9b370d55@pensando.io \
    --to=snelson@pensando.io \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=drivers@pensando.io \
    --cc=krzk@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®