From: Markus Elfring <Markus.Elfring@web.de>
To: Xiu Jianfeng <xiujianfeng@huawei.com>,
cgroups@vger.kernel.org, kernel-janitors@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Waiman Long <longman@redhat.com>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] cgroup/cpuset: Remove unnecessary zeroing
Date: Sat, 25 May 2024 20:55:43 +0200 [thread overview]
Message-ID: <57cef938-fe79-4745-80a1-1285f87cdc7c@web.de> (raw)
In-Reply-To: <20240525094403.1584987-1-xiujianfeng@huawei.com>
> The struct cpuset is kzalloc'd, all the members are zeroed already,
> so don't need nodes_clear() here.
* How do you think about to convert a part of this change description
to an imperative wording?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94
* Please avoid a typo in the domain of an email address.
* Can the proposed source code cleanup be relevant for the addition
of the tag “Fixes”?
Regards,
Markus
next prev parent reply other threads:[~2024-05-25 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 9:44 Xiu Jianfeng
2024-05-25 18:55 ` Markus Elfring [this message]
2024-05-26 18:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57cef938-fe79-4745-80a1-1285f87cdc7c@web.de \
--to=markus.elfring@web.de \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=tj@kernel.org \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®