From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79501C4332F for ; Tue, 7 Nov 2023 11:02:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233949AbjKGLCB (ORCPT ); Tue, 7 Nov 2023 06:02:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232141AbjKGLB6 (ORCPT ); Tue, 7 Nov 2023 06:01:58 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BE98EA for ; Tue, 7 Nov 2023 03:01:55 -0800 (PST) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A7A8O9D024099; Tue, 7 Nov 2023 11:01:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=hYFzKG0Bzit1hbzSGTpLmhkQeKvJs4Z83u1O4jqdkcM=; b=QoVP9h8fEBKk86hL2oeidTKHE2MX6lNAJ2pAt93FpHT8va4mWxHig5qdqmPBYJJh4aDs bA6zIsNmjfS0tI7CMr3kIanVnN+bZasQFmdH8myqIw4UwPg3T6G8T7Gl1e0p26IRnWJ5 hJYkiN9eco5lF45X1XKPpc3vrApWwxJ83JUZnNTOUsYhMo4nNzoBgmZ9CzuMWdyXHLDB z5SuZKrDmfQTgzO8ZJq4AciWrGHHNURonTuE7UAuxMiv3DSpcRQYk7vkjDMT7erYiiq9 ZSFvkomIPawylWqRP+gQMmslm8tQvE2RurLzyM8i7zeGKyGrZfWQp01Q+aqDHYKJT9ou 9w== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u6wer38s6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Nov 2023 11:01:48 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3A7B1lDL022013 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 7 Nov 2023 11:01:47 GMT Received: from [10.214.66.81] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Tue, 7 Nov 2023 03:01:46 -0800 Message-ID: <57d38bd4-d9ea-6ce4-b7c1-1a05097c7338@quicinc.com> Date: Tue, 7 Nov 2023 16:31:42 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] devcoredump: Send uevent once devcd is ready Content-Language: en-US To: Johannes Berg , Greg KH CC: , References: <1699280735-31482-1-git-send-email-quic_mojha@quicinc.com> <2023110659-december-cranium-c98e@gregkh> From: Mukesh Ojha In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: ZJ_YJMCkt_zGn7mLM6yPlVB_IgzHIeTh X-Proofpoint-GUID: ZJ_YJMCkt_zGn7mLM6yPlVB_IgzHIeTh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-07_01,2023-11-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 phishscore=0 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=611 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2311070091 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/7/2023 1:07 AM, Johannes Berg wrote: > On Mon, 2023-11-06 at 20:36 +0100, Greg KH wrote: >> On Mon, Nov 06, 2023 at 07:55:35PM +0530, Mukesh Ojha wrote: >>> dev_coredumpm() creates a devcoredump device and adds it >>> to the core kernel framework which eventually end up >>> sending uevent to the user space and later creates a >>> symbolic link to the failed device. An application >>> running in userspace may be interested in this symbolic >>> link to get the name of the failed device. >>> >>> In a issue scenario, once uevent sent to the user space >>> it start reading '/sys/class/devcoredump/devcdX/failing_device' >>> to get the actual name of the device which might not been >>> created and it is in its path of creation. >>> >>> To fix this, suppress sending uevent till the failing device >>> symbolic link gets created and send uevent once symbolic >>> link is created successfully. >>> >>> Signed-off-by: Mukesh Ojha >> >> What commit id does this fix? >> > > I guess the original introduction. > >> What in-kernel driver does this affect >> that is using devcoredump? >> > > All of them really, it's really about how fast userspace is to access it > after the event. > > Looks fine to me, FWIW, but a Fixes tag wouldn't hurt. Thanks, will add the Fixes tag. -Mukesh > > johannes