From: Andrew Lunn <andrew@lunn.ch>
To: Yeounsu Moon <yyyynoom@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dlink: handle copy_thresh allocation failure
Date: Fri, 12 Sep 2025 22:39:02 +0200 [thread overview]
Message-ID: <57d58296-c656-4dab-a2e2-faf2452fb4de@lunn.ch> (raw)
In-Reply-To: <20250912145339.67448-2-yyyynoom@gmail.com>
> - skb_copy_to_linear_data (skb,
> + skb_copy_to_linear_data(skb,
> np->rx_skbuff[entry]->data,
> pkt_len);
> - skb_put (skb, pkt_len);
> + skb_put(skb, pkt_len);
Please don't include white space changes with other changes. It makes
the patch harder to review.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-09-12 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 14:53 Yeounsu Moon
2025-09-12 20:39 ` Andrew Lunn [this message]
2025-09-14 8:51 ` Yeounsu Moon
2025-09-14 14:45 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57d58296-c656-4dab-a2e2-faf2452fb4de@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yyyynoom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®