From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754817AbdBVMkx (ORCPT ); Wed, 22 Feb 2017 07:40:53 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49287 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754324AbdBVMkp (ORCPT ); Wed, 22 Feb 2017 07:40:45 -0500 Subject: Re: [PATCH v7 0/8] perf: add support for analyzing events for containers To: Jiri Olsa References: <148768564246.30285.16450228018975882950.stgit@hbathini.in.ibm.com> <20170222111117.GA21376@krava> Cc: ast@fb.com, peterz@infradead.org, lkml , acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, daniel@iogearbox.net, rostedt@goodmis.org, Ananth N Mavinakayanahalli , ebiederm@xmission.com, sargun@sargun.me, Aravinda Prasad , brendan.d.gregg@gmail.com From: Hari Bathini Date: Wed, 22 Feb 2017 18:10:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170222111117.GA21376@krava> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17022212-0024-0000-0000-000003A49E46 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17022212-0025-0000-0000-0000111FA019 Message-Id: <57d820b3-ce55-bb9c-1c5f-e8b78d7705e5@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-22_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702220122 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jirka, On Wednesday 22 February 2017 04:41 PM, Jiri Olsa wrote: > On Tue, Feb 21, 2017 at 07:31:11PM +0530, Hari Bathini wrote: >> Currently, there is no trivial mechanism to analyze events based on >> containers. perf -G can be used, but it will not filter events for the >> containers created after perf is invoked, making it difficult to assess/ >> analyze performance issues of multiple containers at once. >> >> This patch-set is aimed at addressing this limitation by introducing a >> new PERF_RECORD_NAMESPACES event that records namespaces related info. >> As containers are created with namespaces, the new data can be used to >> in assessment/analysis of multiple containers. >> >> The first patch introduces PERF_RECORD_NAMESPACES in kernel while the >> second patch makes the corresponding changes in perf tool to read this >> PERF_RECORD_NAMESPACES events. The third patch demonstrates analysis >> of containers with this data by adding a cgroup identifier column in >> perf report, which contains the cgroup namespace's device and inode >> numbers. This is based on the assumption that each container is created >> with it's own cgroup namespace. The third patch has scope for improvement >> based on the conventions a container is attributed with, going forward. >> >> Changes from v6: >> * Updated changelog of patch 1 >> * Split patch 2 into smaller patches >> * Updated record and script documenatation >> * Dropped name field from ns_link_info struct > what's this version based on? I can't cleanly apply it neither > on tip's perf/core or master or Arnaldo's perf/core That's odd. I based my patches against tip's perf/core To be precise, the patches apply cleanly on top of commit 0c8967c9df230d2c4dde6649f410b62e01806c22. Thanks Hari