mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Haoxiang Li" <haoxiang_li2024@163.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "Ostrovsky, Boris" <boris.ostrovsky@oracle.com>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"david.vrabel@citrix.com" <david.vrabel@citrix.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"tglx@kernel.org" <tglx@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"bp@alien8.de" <bp@alien8.de>,
	"oleksandr_tyshchenko@epam.com" <oleksandr_tyshchenko@epam.com>,
	"jgross@suse.com" <jgross@suse.com>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] xen/grant-table: fix resource leak in gnttab_init()
Date: Sat, 21 Nov 2026 14:40:51 +0800 (CST)	[thread overview]
Message-ID: <57e13adb.164a.1a1fcd618cf.Coremail.haoxiang_li2024@163.com> (raw)
In-Reply-To: <ceade382ab685f63b90b5bda405363db01f486e7.camel@intel.com>


At 2026-11-21 06:06:58, "Edgecombe, Rick P" <rick.p.edgecombe@intel.com> wrote:
>
>I guess since you injected the error you didn't hit this in practice? If so, I'd
>think this would be a pretty low priority fix. The combo of rare scenario and
>close to zero user impact. Fine to be corrected though.

I agree that this failure is unlikely to happen. I found the missing cleanup using a
static analysis tool and check the leak with fault injection. But hard to prove
that it will happen in normal userspace.

Regards,
Haoxiang Li

      reply	other threads:[~2026-11-21  6:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  8:43 Haoxiang Li
2026-11-19 23:18 ` Edgecombe, Rick P
2026-11-20  5:56   ` Haoxiang Li
2026-11-20 22:06     ` Edgecombe, Rick P
2026-11-21  6:40       ` Haoxiang Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57e13adb.164a.1a1fcd618cf.Coremail.haoxiang_li2024@163.com \
    --to=haoxiang_li2024@163.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mingo@redhat.com \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=sstabellini@kernel.org \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®