mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gopi Krishna Menon <krishnagopi487@gmail.com>
Cc: sre@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	lee@kernel.org, conor+dt@kernel.org, daniel.baluta@nxp.com,
	simona.toaca@nxp.com, d-gole@ti.com, m-chawdhry@ti.com,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: reset: st: convert to dtschema
Date: Wed, 25 Mar 2026 13:36:15 +0100	[thread overview]
Message-ID: <57e3e846-d679-4201-921c-69cdd4040d13@kernel.org> (raw)
In-Reply-To: <acPMx9NZBehAzkBp@toolbx>

On 25/03/2026 13:04, Gopi Krishna Menon wrote:
> On Wed, Mar 25, 2026 at 12:39:36PM +0100, Krzysztof Kozlowski wrote:
> 
>> On Tue, Mar 24, 2026 at 09:29:30PM +0530, Gopi Krishna Menon wrote:
>>> Convert the STiH4xx reset controller bindings to DT schema.
>>>
>>> Suggested-by: Daniel Baluta <daniel.baluta@nxp.com>
>>> Suggested-by: Dhruva Gole <d-gole@ti.com>
>>
>> Both suggested you to write this patch?
>>
> Hi Krzysztof,
> 
> Thanks for the review, They helped me to improve the PATCH,
> 
> - Dhruva suggested me to change the subject from dt-bindings: power:
>   reset: st: convert to dtschema to dt-bindings: reset: st: convert to
>   dtschema as that was the general trend followed with similar files.
> - Daniel suggested me to use the word 'reset' instead of 'restart' in
>   the patch (whereever possible) as that is more accurate here.
> 
> That's why I added those Suggested-by tags.

This is not the meaning of Suggested-by. Drop the tags.

I gave you now review, so you will add "Suggested-by: Krzysztof ..."?

Best regards,
Krzysztof

  reply	other threads:[~2026-03-25 12:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 15:59 Gopi Krishna Menon
2026-03-25 11:39 ` Krzysztof Kozlowski
2026-03-25 12:04   ` Gopi Krishna Menon
2026-03-25 12:36     ` Krzysztof Kozlowski [this message]
2026-03-25 13:13       ` Gopi Krishna Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57e3e846-d679-4201-921c-69cdd4040d13@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=d-gole@ti.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krishnagopi487@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=robh@kernel.org \
    --cc=simona.toaca@nxp.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome