From: Shuah Khan <skhan@linuxfoundation.org>
To: "Mark Brown" <broonie@kernel.org>,
"Shuah Khan" <shuah@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Ricardo B. Marlière" <rbm@suse.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: Deescalate error reporting
Date: Thu, 16 Apr 2026 15:14:13 -0600 [thread overview]
Message-ID: <57e570f4-af6d-4055-8464-2a2d552542f1@linuxfoundation.org> (raw)
In-Reply-To: <20260416-selftests-deescalate-error-reporting-v1-1-38e7c0536227@kernel.org>
On 4/16/26 07:19, Mark Brown wrote:
> Commit 7e47389142b8 ("selftests: Preserve subtarget failures in
> all/install") updated the propagation of errors from indivdual kselftest
> targets to be similar to that seen with FORCE_TARGETS. While it would
> be really nice to be in a position to do this currently it is premature
> to do this as the default behaviour.
>
> At present we default to trying to build all selftests but a combination
> of code quality issues and build dependencies mean that it is almost
> certain that at least one of them will fail to build (for example,
> several depend on clang so don't work in a GCC container) and a top
> level failure in the kselftest build reported. Further, the resulting
> failures mean that the install target does not run at all so any build
> problem is escallated to a complete failure to produce a kselftest
> tarball so CI systems that run into issues loose all selftests coverage.
> This has been causing disruption to a range of CI systems including
> KernelCI, mine and Arm's internal one.
>
> Revert the commit, users who need this behaviour should be able to use
> FORCE_TARGETS for the time being. At present users that do this (such
> as linux-next) are most likely building a subset of targets known to
> succeed in their environments.
>
> Fixes: 7e47389142b8 ("selftests: Preserve subtarget failures in all/install")
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> tools/testing/selftests/Makefile | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Thank you. I applied it to linux-kselftest next and will send pr tomorrow.
thanks,
-- Shuah
prev parent reply other threads:[~2026-04-16 21:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 13:19 Mark Brown
2026-04-16 21:14 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57e570f4-af6d-4055-8464-2a2d552542f1@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=rbm@suse.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®