From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755259AbdDNVDH (ORCPT ); Fri, 14 Apr 2017 17:03:07 -0400 Received: from mout.web.de ([212.227.15.14]:54136 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573AbdDNVDF (ORCPT ); Fri, 14 Apr 2017 17:03:05 -0400 Subject: [PATCH 2/2] regulator: s2mps11: Use devm_kmalloc_array() in s2mps11_pmic_probe() From: SF Markus Elfring To: linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Sangbeom Kim Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <57e9c3a5-3751-41ee-3b70-f532fb928571@users.sourceforge.net> Date: Fri, 14 Apr 2017 23:02:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:AMGtQXEtlTlWQ943rVILf3SbAohMnM1pvUh8WqPFqwmqIeVnz9l OhAchebQXtqPu6RdC5mHJWDginMcqx3vlvhCkkQxClMUOQG3zT86PRtKJHMS9vNan6vkWdf HeyNL+1j+6A48OZepOeDU8uMEdexoNEGFLs9qvbs8KIWS/CrI2r27v0nhgQuHt0X8wSN5FI ujIJ2tC4i0vt2rMMxnAYA== X-UI-Out-Filterresults: notjunk:1;V01:K0:nwbBlNT1bUg=:FRpR6MuUUzlITduazg3g+8 DMja6EC9NbzevTxMoT9ySvYRH37Ux1dJ8NMjv33UUJTLYzNgdfrMdwjpk+FokQqnHaVA/d9Tm JW63EVHDNzFq/L7nrxYbN/T1HkV2u0bGxSN/IQJz6WsVezuix6LzJNF6mIxILtfih3gkXSFWp LgCIbx8aJ9ae6OSPkjr/AinrRBnPflNcvzKSZ+Xf5lfbrOnZjRKqRf8FHC8XOgRRp+eo7dh6m EZ/qcaBaYeKqkFT9A6Gdb+WhPUVYOAmXKkwXGOLv9kmA2YjgAFhHRcqq8brAzuW/7Utt5tUWg gNo10Xx+NwwRYJQ+1JRaPR7glzq6DoOAgyZlPTVwTae0eYaOHlHCiH23Z2RgxgO3Wj+LKaAvv gNIbnF/p75HYMvo1b2mEWw1dLo+5mTMb5Sdp9U1FvT1fFBEXJq1RP+yKjxeV9qP8kw5YS4PHk JqgLnYFyOlYLy4d+q1H+qxw1NJ5SbOWhUWOIG2zTcpftFAZB7JYimJkXGA/NLWSIoKy8w0it6 GiGWTOCHcjTKKZ7TIZK3rKqdgo5WHON4AJs6RhjmylvsBPzisuh4wNRrva40+73g/tZ93+Zu/ 1gShxOBY6rCLcSzuZlty5aTODJwWCILpGtbaqGGAHqdAae+qU+Le4ZwXa7gL0C+U1Le+ephk7 JjHno+xJ6OTtql5FL8Civfr9y30ohkj4drUCYSN3KsLG9apWQX6xejhat13TJjXbR4qONJNam UM0ef2TUJNlaPQf3gQ+fGMs68Tnz3qV6UCKpN6i5+ZymTF7pwt7BLdvu2hKt3wEJ83XDrq2We raXHDge Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 14 Apr 2017 22:40:19 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/regulator/s2mps11.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index b4e588cce03d..b397a2e0bcd1 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -1139,9 +1139,11 @@ static int s2mps11_pmic_probe(struct platform_device *pdev) return -EINVAL; } - s2mps11->ext_control_gpio = devm_kmalloc(&pdev->dev, - sizeof(*s2mps11->ext_control_gpio) * rdev_num, - GFP_KERNEL); + s2mps11->ext_control_gpio + = devm_kmalloc_array(&pdev->dev, + rdev_num, + sizeof(*s2mps11->ext_control_gpio), + GFP_KERNEL); if (!s2mps11->ext_control_gpio) return -ENOMEM; /* -- 2.12.2