From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932458AbcKBUJH (ORCPT <rfc822;w@1wt.eu>);
        Wed, 2 Nov 2016 16:09:07 -0400
Received: from nm21-vm3.bullet.mail.ne1.yahoo.com ([98.138.91.151]:43967 "EHLO
        nm21-vm3.bullet.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S932179AbcKBUJG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 2 Nov 2016 16:09:06 -0400
X-Yahoo-Newman-Id: 215743.7022.bm@smtp203.mail.ne1.yahoo.com
X-Yahoo-Newman-Property: ymail-3
X-YMail-OSG: QIE60Z8VM1lNe7y12Fs35yO8Egbg.9hh7MZasQodBW13zuc
 IJvoM1gmZReBHYOfpurv_5SknAH5gUAWAw2ImzVYPcJx0KRM5MSPiR3dhffi
 bekaT8.DsFU_2Bd6vhZBt2uutMJC77j5oHjlmxEfYLdKb4.4iDTL4nXxcO32
 oU9byd_WMucEbi1gDzyM8jYr1ukW1Fi11V9ZyLKAZAn1QeujgHMA5pwcSG_d
 rrsLjQvSKQTFgaB6LGWHqSL5Q2J63mfdrzkLXuvuU0rw0af5tdtYZ3ISJkb2
 r8zd8XrKYXG21lmoBRYSN0awxxFi0UUTpvLz7.JJRmqp_rFEDdX0fIRpqZxh
 b5YA4o89RvnGGbsH6yEfPU4fVr90LgHB_SzTMT5j3LV3wet2tTmlThtKqZxZ
 PRjJJPvxFR6kz2ClltIs3ECQWGYzPC3oDijJcy_tvh6DHSk8iiMTMU.4TQhE
 fLveSj3ffqgrmnl9IpoAqgH09vp1V22WbhMVJs3NjpJwyRYx4ci_pdFWBAWe
 KFhq7TAGr46i9yH8OwoOeUBfAVqJCh9c5Q1YwOmIeo5xEGbX46v0QZjQ-
X-Yahoo-SMTP: OIJXglSswBDfgLtXluJ6wiAYv6_cnw--
Subject: Re: [PATCH] Re: Problem with setxattr on sockfs with Smack after
 971df15bd54ad46e907046ff33750a137b2f0096
To: Andreas Gruenbacher <agruenba@redhat.com>
References: <ab02d571-b4ab-3348-87d6-03cd0889f041@schaufler-ca.com>
 <bf76b2ed-0974-2bae-a9f8-5bf40d30d20e@schaufler-ca.com>
 <1478115261-29669-1-git-send-email-agruenba@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, linux-kernel@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        Stephen Smalley <sds@tycho.nsa.gov>,
        Casey Schaufler <casey@schaufler-ca.com>
From: Casey Schaufler <casey@schaufler-ca.com>
Message-ID: <57e9db81-d785-98ab-dd52-47c1f82c76c3@schaufler-ca.com>
Date: Wed, 2 Nov 2016 13:09:01 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1478115261-29669-1-git-send-email-agruenba@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/2/2016 12:34 PM, Andreas Gruenbacher wrote:
> Casey,
>
> does this patch help?

My tests pass with this patch applied.

>
> (The way how security xattrs are handled by LSM is pretty ugly.

I'm open to suggestions.

>   I'm not
> convinced that it doesn't break something else, yet.)
>
> Thanks,
> Andreas
> ---
>  fs/xattr.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xattr.c b/fs/xattr.c
> index 3368659..bf09836 100644
> --- a/fs/xattr.c
> +++ b/fs/xattr.c
> @@ -183,11 +183,13 @@ int __vfs_setxattr_noperm(struct dentry *dentry, const char *name,
>  			security_inode_post_setxattr(dentry, name, value,
>  						     size, flags);
>  		}
> -	} else if (issec) {
> -		const char *suffix = name + XATTR_SECURITY_PREFIX_LEN;
> -
> +	} else {
>  		if (unlikely(is_bad_inode(inode)))
>  			return -EIO;
> +	}
> +	if (issec && error == -EOPNOTSUPP) {
> +		const char *suffix = name + XATTR_SECURITY_PREFIX_LEN;
> +
>  		error = security_inode_setsecurity(inode, suffix, value,
>  						   size, flags);
>  		if (!error)