From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 623BB1DD86E for ; Mon, 6 Jan 2025 13:35:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736170511; cv=none; b=pNlZnGn+7Eiljmq7eqEBQjfA6UPPzE5jQoQqQP4QVeewb6G+4vEH5ZT9HZxHXOGFPJPWB71fHrXe6FSI7+UxtI3UahpgcZmWeLAXaqQ64O6WtKmUlsxZ+yLvOdWWKSuYsXf4IFg2R67kJBuz0BPIgz7v+8K12uelxQ+c6SAmaek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736170511; c=relaxed/simple; bh=rzubnT0gas16PzeOBWAv24OQZ7te5xw5qxzCAysoAMo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=D5RLhwXLQhrZ/fM/EpZpZU8D4zBC5pAxh+CLwmiZ+7wGFZ51fsXseJHCx3pUvsblHEO7neFge3KtQIzxvscZtVia/eNlOruz6nPS8WoLubXZTJ3QwIWdZm2T5bu+Kdi4G867o0QNKBRl5/VTq3QqcLQLkgc/kC76fu7qj9oVKOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=F8yWxxpn; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="F8yWxxpn" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-21636268e43so22626305ad.2 for ; Mon, 06 Jan 2025 05:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736170508; x=1736775308; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dSl9CiTNSQwE0RKlCdBtogvBaV/TE9/iFGVUzDM7I3Y=; b=F8yWxxpn99xl6RSYcERdON6gNNnB5asuoZxu9+IiKhnbHtzVBKmaMwFOzzQbvYhySj nh6VUUrLeDq6AAXMXq/jAJ2VQolB9McY5VZE0rbL5jcDDdnEFC46jw/4AhXX7aen6Ty0 UNa2mEJlz1X9sq5S+X9LBViB3JGYE2nlUvFICMDM6UWb6v2sF4soUCtUVwnWBF5Z/TWe Cd1G0zka+EO70usIOt9JQR75ipBZxl2Uz8loGmmPvNgXkiKeYK4/PpzvaxxzLEOLJcUj Z41cGVJP9D2tjsC373FIWLE0htTiClZQVQ6GqdjjSBFlJ3uLdhUpZgLJYNc+e0KD9w7m 97mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736170508; x=1736775308; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dSl9CiTNSQwE0RKlCdBtogvBaV/TE9/iFGVUzDM7I3Y=; b=Jn84CaI45S55GIf7LWN8wyg26iJWukVCbpwbk6jnkk4Q1dp4PDQI5zrC9oyJZ3h4Af QlV8+SkmhORQWJ9LjqX0i8Bsgf46fNFMzrO4NglamrfixuHKs2SvlbIRWL7yXqxyu5IM D6vd8PCFAfJsoQxKxxxXLcZ47N6b9vZkDYueZJAmec7gWem+5Awc/FHgJW8JMYZrlFwf AKG45ZPvEWLak1jL0HH7fjx4Yl2TAv8QUSP9pp6xlmWO3hXGbloyVmv6RdId558jJzPY SNSM5D5YhvkdRJVeR5xKBFcmROC/u1eGDyByXZ2C5D7FWkcTVagq6qHMOAa1sHh4w1mS HhDQ== X-Forwarded-Encrypted: i=1; AJvYcCVe1G9wLCLllnUO0kElbO9dQlpWNAxDzHGf9k6NoorSPY61FDCmNKUwIDkmZiHLieseL/w89wbKnr7R+Kc=@vger.kernel.org X-Gm-Message-State: AOJu0YwCeAhvC5Ojlpli2QQH08+BXyHR7fql64579jO2DG59c/TJE/Mx KyG6Ma1AucGKjLGl2NIjzex4CeeCPxaGSSXPQf01TEGfL8ZXJgOYrl0szDsi13Y= X-Gm-Gg: ASbGncuOK+pjJNzD4Vv9QYGN+ExNOgdXRbMGMmKd7wheLG1qfQGf+jzPvtEjkHCpY9V c++lY1ErtD3gh7Ckhe/mJWP3EU9/EJY/9Q2V0CNkdi1HEaEuk5enB0SYCArSuycn8jFuP5BYFVO jszCSSMjHVKMDQf46Y9kT1JEKzZZOYgK6PeSVGh1awZN5duwukFqJiDTLnVWInMOzS6mOukSFyi uMYgZYgb7UsIz0xR1c4dEemO+4Gk8CyoVWbQVhz6Ctjqb2kM8d5DZBoNdCE5HVJjQoOZ7APODdJ 9YSD2YmfxtrhQ8IWvFcrjKoTsseo0seKl1qdWTE/z8kDNX+m41dO X-Google-Smtp-Source: AGHT+IFuxfmftFbdw6fO4bIMnZYJ/q+si7Sq93AxF4PGQarIeYtLJTB7gRBGy3tWc8bUzZwj1LueBQ== X-Received: by 2002:a17:902:e844:b0:216:3083:d03d with SMTP id d9443c01a7336-219e6f13c50mr852868805ad.44.1736170508636; Mon, 06 Jan 2025 05:35:08 -0800 (PST) Received: from ?IPV6:2409:8a28:f44:d64:296c:a8f3:f81e:f88b? ([2409:8a28:f44:d64:296c:a8f3:f81e:f88b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9cdf02sm292469725ad.151.2025.01.06.05.34.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 05:35:08 -0800 (PST) Message-ID: <57ea8193-2fd9-41a9-85b4-7af924f900f4@bytedance.com> Date: Mon, 6 Jan 2025 21:34:55 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/15] s390: pgtable: also move pagetable_dtor() of PxD to __tlb_remove_table() Content-Language: en-US To: Alexander Gordeev Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <2d16f0fe-9c7f-4229-b7b5-ffa3ab1b1143@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/1/6 20:44, Alexander Gordeev wrote: > On Mon, Jan 06, 2025 at 07:02:17PM +0800, Qi Zheng wrote: >>> On Mon, Dec 30, 2024 at 05:07:47PM +0800, Qi Zheng wrote: >>>> To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of >>>> PMD|PUD|P4D to __tlb_remove_table(). >>> >>> The above and Subject are still incorrect: pagetable_dtor() is >>> called from pagetable_dtor_free(), not from __tlb_remove_table(). >> >> Hmm, __tlb_remove_table() calls pagetable_dtor_free(), so moving to >> pagetable_dtor_free() means moving to __tlb_remove_table(). Right? > > Right. But you Subject and description claim "... also move the > pagetable_dtor()" not to pagetable_dtor_free() - which is another > function. OK, will change the subject and description to: s390: pgtable: also move pagetable_dtor() of PxD to pagetable_dtor_free() To unify the PxD and PTE TLB free path, also move the pagetable_dtor() of PMD|PUD|P4D to pagetable_dtor_free(). But pagetable_dtor_free() is newly introduced in this patch, should it be changed to 'move ... to pagetable_pte_dtor_free()'? But this seems strange. :( > >> And the main purpose of this patch is also to move pagetable_dtor() >> to __tlb_remove_table(). So I think this description makes sense? > > The patch makes sense, but the description it is incorrect ;) > > Thanks! Thanks!