From: Krzysztof Kozlowski <krzk@kernel.org>
To: Elaine Zhang <zhangqing@rock-chips.com>,
mturquette@baylibre.com, sboyd@kernel.org,
kever.yang@rock-chips.com, heiko@sntech.de
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
huangtao@rock-chips.com
Subject: Re: [PATCH v1 2/2] clk: rockchip: rk3588: Adjust the GATE_LINK parameter
Date: Thu, 27 Jul 2023 13:21:17 +0200 [thread overview]
Message-ID: <57ed9bd0-dc90-69ef-31fb-4eb5d821190d@kernel.org> (raw)
In-Reply-To: <20230727101139.23048-3-zhangqing@rock-chips.com>
On 27/07/2023 12:11, Elaine Zhang wrote:
> Using Id instead of name, if use name needs to use __clk_lookup().
> But __clk_lookup() is not exported and is not friendly for GKI.
>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> ---
> static void __init rk3588_clk_init(struct device_node *np)
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index b5616bca7b44..864a321ab362 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> @@ -733,8 +733,9 @@
> #define ACLK_AV1_PRE 718
> #define PCLK_AV1_PRE 719
> #define HCLK_SDIO_PRE 720
> +#define PCLK_VO1GRF 721
Bindings are separate patches.
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-07-27 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 10:11 [PATCH v1 0/2] clk: rockchip: add GATE_LINK Elaine Zhang
2023-07-27 10:11 ` [PATCH v1 1/2] clk: rockchip: add support for gate link Elaine Zhang
2023-07-27 10:11 ` [PATCH v1 2/2] clk: rockchip: rk3588: Adjust the GATE_LINK parameter Elaine Zhang
2023-07-27 11:21 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57ed9bd0-dc90-69ef-31fb-4eb5d821190d@kernel.org \
--to=krzk@kernel.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®