mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Vitaly Mayatskih <v.mayatskih@gmail.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, stefanha@redhat.com
Subject: Re: [PATCH 0/1] vhost: add vhost_blk driver
Date: Tue, 6 Nov 2018 10:45:08 +0800	[thread overview]
Message-ID: <57eefa62-7e66-786d-441c-5dd6b0d451a5@redhat.com> (raw)
In-Reply-To: <CAGF4SLg6+nt+zV4haXys4Wz2dWPDyx7xHXuA+h01NcQ94j0E1A@mail.gmail.com>


On 2018/11/5 上午11:23, Vitaly Mayatskih wrote:
> On Sun, Nov 4, 2018 at 10:00 PM Jason Wang <jasowang@redhat.com> wrote:
>
>>> # fio num-jobs
>>> # A: bare metal over block
>>> # B: bare metal over file
>>> # C: virtio-blk over block
>>> # D: virtio-blk over file
>>> # E: vhost-blk bio over block
>>> # F: vhost-blk kiocb over block
>>> # G: vhost-blk kiocb over file
>>> #
>>> #  A     B     C    D    E     F     G
>>> 16 1480k 1506k 101k 102k 1346k 1202k 566k
>> Hi:
>>
>> Thanks for the patches.
>>
>> This is not the first attempt for having vhost-blk:
>>
>> - Badari's version: https://lwn.net/Articles/379864/
>>
>> - Asias' version: https://lwn.net/Articles/519880/
>>
>> It's better to describe the differences (kiocb vs bio? performance?).
>> E.g if my memory is correct, Asias said it doesn't give much improvement
>> compared with userspace qemu.
>>
>> And what's more important, I believe we tend to use virtio-scsi nowdays.
>> So what's the advantages of vhost-blk over vhost-scsi?
> Hi,
>
> Yes, I saw both. Frankly, my implementation is not that different,
> because the whole thing has only twice more LOC that vhost/test.c.
>
> I posted my numbers (see in quoted text above the 16 queues case),
> IOPS goes from ~100k to 1.2M and almost reaches the physical
> limitation of the backend.
>
> submit_bio() is a bit faster, but can't be used for disk images placed
> on a file system. I have that submit_bio implementation too.
>
> Storage industry is shifting away from SCSI, which has a scaling
> problem.


Know little about storage. For scaling, do you mean SCSI protocol 
itself? If not, it's probably not a real issue for virtio-scsi itself.


>   I can compare vhost-scsi vs vhost-blk if you are curious.


It would be very helpful to see the performance comparison.


Thanks


> Thanks!

  reply	other threads:[~2018-11-06  2:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02 18:21 Vitaly Mayatskikh
2018-11-02 18:21 ` [PATCH 1/1] Add " Vitaly Mayatskikh
2018-11-02 18:36   ` Michael S. Tsirkin
2018-11-02 19:24     ` Vitaly Mayatskih
2018-11-02 20:38       ` Michael S. Tsirkin
2018-11-03  2:50   ` kbuild test robot
2018-11-06 16:03   ` Stefan Hajnoczi
2018-11-06 19:47     ` Vitaly Mayatskih
2018-11-02 18:26 ` [PATCH 0/1] vhost: add " Michael S. Tsirkin
2018-11-02 18:31   ` Vitaly Mayatskih
2018-11-05 14:02   ` Christian Borntraeger
2018-11-05 14:21     ` Vitaly Mayatskih
2018-11-06 15:40   ` Stefan Hajnoczi
2018-11-06 18:46     ` Denis Lunev
2018-11-06 20:08     ` Vitaly Mayatskih
2018-11-04 11:57 ` Maxim Levitsky
2018-11-04 16:40   ` Vitaly Mayatskih
2018-11-05 11:55     ` Maxim Levitsky
2018-11-05  3:00 ` Jason Wang
2018-11-05  3:23   ` Vitaly Mayatskih
2018-11-06  2:45     ` Jason Wang [this message]
2018-11-06  2:56       ` Vitaly Mayatskih
2018-11-06  7:13       ` Christoph Hellwig
2018-11-06 21:41         ` Paolo Bonzini
2018-11-05 15:48   ` Christian Borntraeger
2018-11-05 16:15     ` Vitaly Mayatskih
2018-11-06 15:21       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57eefa62-7e66-786d-441c-5dd6b0d451a5@redhat.com \
    --to=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=v.mayatskih@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®