From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41DC63D903C for ; Mon, 15 Jun 2026 15:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781539015; cv=none; b=DHRKsqkwv22hEnZ5YKvOC66FU2rDSKe7P8xWca9RX26W7Xe8F9AoLO90BZK1X6wcp3U7nyGfaBXo28lk09mKKZLDTGpA66lACmfzMrxmvAAfF+tFiXXHNhRhLP1MCm7o9vA8YkAbFSU8VnIFHWlsRtzOZtbt1LHQysFVCcsg+b0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781539015; c=relaxed/simple; bh=VC4ByHWhUnEY9FgLt9VYI53AreHcL/oYIeZhf09f3ms=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MQLlmEP4nMeL6mlvU4h+QTqGSOiO804C2HUWI8vESja8kd0ytWoQnNEo6JTroEAwQeMjMnud6XtUwqlDDCyg6eUh5bMBKCBrTYMfJp2kioEcNp31MJBVyguvm5MwBJzfNo3UJbBJLuJxtuzYm9XsSdbVhN3DirQ1Aok0DxGDBqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pNg4LYxG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MGxMxq1x; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pNg4LYxG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MGxMxq1x" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FFhWES805388 for ; Mon, 15 Jun 2026 15:56:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aJpg6TL0Li8c78MGRrrP7ZdsT1joHJVHeC0IPMlRV/Q=; b=pNg4LYxGnJo1YLrt JHGSSXZ8d7vc0xwLIS30M2ktRnCS0DFopofofc7jU9FNC6yQaqFb4jaOY5y7ivd+ klX7wuClE+8iYKkucw1aar8fnc7XJTpUh7MAe3Tkb3mBmwtbtsjKIO9ffZHzRqzt uWlud+LwQD96K4/i0PgrOY6nywBiVGqsfabNVvniPsnDkXlVkApOTczH6dQWIonk 2j+NIvrFHhGcFIohspRATPthTdoudOoYFOL+nVmTdgb6bzvoLk3tPI7tJkBjU7aB QOzlOypUAyKwW51g+SgSV7EPbk0gskVP8yLIol/C0wxFTZWK/po8G4mAqiep9dnr OKMX7g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etetf1jn7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 15:56:53 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-91571f0d3e3so11716285a.0 for ; Mon, 15 Jun 2026 08:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781539012; x=1782143812; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aJpg6TL0Li8c78MGRrrP7ZdsT1joHJVHeC0IPMlRV/Q=; b=MGxMxq1xJRWMR/hK6ZRPQYMOFfRISWKNwKXZ4YL34O+ytzGQ2ft1fugteUczRR9ktR 5FM4f9Iax3eElC/kZ2fWFeBizXLsToAdKMIKlFQJ1vHh7l8B+SjOPSq5k129uBZJG0Y0 28e71yzeVIOWGxmm7VDkjaxWlEJ3MfgD2YMshLpuVCPdHexA4EuIbSeQVkaWlDKgyLWE nL9iwxfmgfliE+wIzG4sxr9mbgM2vDgyZcOb2Q+RjQLeOmDqbCVZK4uSyiFTxl2pLJSk aZhM+WJKntfsSYpIPuWjyOlUbwH1E3u3E/3P9TAHXJxL7JATMMk/Jw4DhrIsUdingWQW RBfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781539012; x=1782143812; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aJpg6TL0Li8c78MGRrrP7ZdsT1joHJVHeC0IPMlRV/Q=; b=Q32bLZK3M4zjFP+xM4io8y7eVmWQ2P6KRlvTlNrl8nk74Uy+6AnQXdLPWcxMn2p7Os G0/IjhkaW8u8J9r3r9vz04bFmgLaQs/vmxI1hnp6RI6LFPFv7V6qKPocqDhZQLewYwpD WmcJ7hin6iJSX0XcUHFH9lYvRjG1b51a5y76XR1iCrs91tdUg0EcMIkkSra3e4L0gNWf wYQNdLckn99g1xeI/7w6pLgMEJ4BHDiOsJuJqIPphq+IvLkcOJ0vFLq018u3KtfqubLs 9MKr42f6kRZJ3yiK3F34gGRmFoumzrRnGHFcul3luacHMcWhNWCDrJDD/rYhBWswMt0W hCcQ== X-Forwarded-Encrypted: i=1; AFNElJ/yQWqt6FXZXNRN34SN4aApu/S7uRl+CQ7usrNnAPMnXyawvRH+2YB68txp1fqY0lrSeySNmxmptGcN31E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7JqU4641eGPy8XqOqXXkSdnfZD87kT8Wlu4RZzHgwOcjQpZVh u24bkn+69oOPmYKiqtb8JsYZN7gPv2pga0qv2/D8CKu23z2HdXxQMfUQX32/FpNuaEQeJYBwcyz Fo8SNesEbQ3kdrmu46+vYqDUT0ZkgRvLstPpzgAsgfJpe/2uYvSc3PJ6iiUgEQuk+Eh4= X-Gm-Gg: Acq92OHS65Bzy1By8iVg2AlcdFjWO4gpfbw0ac4fXx6FBWcs2WF9CzC4mcX7Ew4U6Uw MlJ7hrXQsIqKTQhgJHfXQB7N+bnR+vMrm4TgLCDgRrxaKJ8CA7lhd0mC3mud3WO+9MoJpJ9L6/w R7W3QoD3Baw4CdxbNpg5loSvjalxRqcW7N7XN7aFEjF+t43Cfz7aDI3yLMin4Eq61TS79jmjcMD xzFtnLU8zbx4Th4hgudl+NujkGlZ2E5LtB0sHBUTMqj3ge7O9RPyaygVp2fVgD3M1cHdWPY8X+H I5b4OJuPJr31J34dDdmugfy5AkvShitTIP73bQn5zfbq6qSQ7X0ffDngHgKTL+i+tXkDIwaDqXW tVuMzaMjX9hZHwlwLe76s2xz+N9PZp+4CEXtA4zHcdnMstw== X-Received: by 2002:a05:620a:394b:b0:915:54b2:582d with SMTP id af79cd13be357-9161bd659b1mr1367739185a.8.1781539012582; Mon, 15 Jun 2026 08:56:52 -0700 (PDT) X-Received: by 2002:a05:620a:394b:b0:915:54b2:582d with SMTP id af79cd13be357-9161bd659b1mr1367735385a.8.1781539012090; Mon, 15 Jun 2026 08:56:52 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c03ba328d6dsm69770866b.49.2026.06.15.08.56.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 08:56:51 -0700 (PDT) Message-ID: <57f3407f-3371-4db7-87cc-218f7360ce3f@oss.qualcomm.com> Date: Mon, 15 Jun 2026 17:56:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: qcom: lemans-pmics: Add ADC support for PMM8654au To: Jishnu Prakash , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayyagari Ushasreevalli , Kamal Wadhwa References: <20260430-adc5_gen3_dt-v1-0-ab2bb40fd490@oss.qualcomm.com> <20260430-adc5_gen3_dt-v1-2-ab2bb40fd490@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260430-adc5_gen3_dt-v1-2-ab2bb40fd490@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=adxRWxot c=1 sm=1 tr=0 ts=6a3020c5 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=6xfqC-53WEIPg_2uNRIA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: M_EOkvmP_fFPzdl3UmozsYAwJc3amJtn X-Proofpoint-ORIG-GUID: M_EOkvmP_fFPzdl3UmozsYAwJc3amJtn X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE2OCBTYWx0ZWRfXx1QJVJEv7VlW chvN87aUB6CH5E2KnGjyAPwCZj5vYA/RoA5ywoS8Via8GNHt8WGq77/E7FmsShj+iXY3MXu+nfC e0xeScG9prSpKb9ySX88YeIuTuGbnB0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE2OCBTYWx0ZWRfX/Pgmdl/zmW5s 7ykb06reb0RcWTlNYMpncC9keKHc7RcsSpnvVvsAtsqVHMqF35cff9PtP4azPF7T4bKrsexnQ0M ExASl0WclKc05XMLXE2YKKhbdlC8vmoyQNbYNujKYBVvwMF7dqcMlZCZ6LLoF4gOTgRR72ClJnf Rsh5KNwwrth6vP0xeiM1EOX+WqwP4tDCEX95t7zEnArXe6VQHKZNHzQHst6yPhxt0WC1CRayDzo jfb/S0ypHaaZj7pDzt7kNbmeElQmSHhhxxEnzYedR/WLzJeu/kx4zWBAy9Xa8efb7j57UDBd4Y/ IjY68JqzIt2dewIpvQspO/xqlGLlR4h1SkYNqGKR5NiDsZUuSFgnPwX85Mfnq5dU2EpMlOOZ08E ENIfH0+6t57laqzQJ3D29UlrND1xxbNyIf0LBZWbZHBf8F6zcl6NcNrWi9WZIkx6Pg1B0b7EUit E8ym7nb26C5D7e/RaDw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_04,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150168 On 4/30/26 10:58 AM, Jishnu Prakash wrote: > From: Ayyagari Ushasreevalli > > Add ADC nodes for the four PMM8654au PMICs (pmm8654au_0 through > pmm8654au_3) on the Lemans platform. > > Each ADC node exposes the following ADC channels: > - DIE_TEMP: PMIC die temperature channel > - VPH_PWR: Battery/supply voltage channel > > Also add the io-channels and io-channel-names properties under > the temp-alarm nodes so that they can get temperature reading > from the ADC die_temp channels. > > Signed-off-by: Ayyagari Ushasreevalli > Signed-off-by: Jishnu Prakash > --- > arch/arm64/boot/dts/qcom/lemans-pmics.dtsi | 93 ++++++++++++++++++++++++++++++ > 1 file changed, 93 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi > index 341119fc8244..6caec3e4df4b 100644 > --- a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include "qcom-adc5-gen3.h" > > / { > thermal-zones { > @@ -110,6 +111,8 @@ pmm8654au_0_temp_alarm: temp-alarm@a00 { > reg = <0xa00>; > interrupts-extended = <&spmi_bus 0x0 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; > #thermal-sensor-cells = <0>; > + io-channels = <&pmm8654au_0_adc ADC5_GEN3_DIE_TEMP(0)>; > + io-channel-names = "thermal"; > }; > > pmm8654au_0_pon: pon@1200 { > @@ -141,6 +144,27 @@ pmm8654au_0_rtc: rtc@6100 { > interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>; > }; > > + pmm8654au_0_adc: adc@8000 { > + compatible = "qcom,spmi-adc5-gen3"; > + reg = <0x8000>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupts = <0x0 0x80 0x1 IRQ_TYPE_EDGE_RISING>; > + #io-channel-cells = <1>; > + > + channel@3 { > + reg = ; > + label = "pmm8654au_0_die_temp"; Are these labels namespaced, i.e. can the label be just "pm8654au_die_temp" or "die_temp"? Konrad