From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA50A35EDD6 for ; Wed, 14 Jan 2026 07:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375629; cv=none; b=XG8qrx8/y3PqxvQuBvBKNSvoXvULKDxU0ZJOzrWS+6RfHmM3/RlTJHylEwzLZT7Mwu3InY33onjbm4UOfy/h6OHsGEGIM7Y9JJkYvB3eP86tV5+NStFy93V9BS6CA7QzGvCAoggjJcqs7L5Akaj107OOKxi/BsZHly6XRV+Vaog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375629; c=relaxed/simple; bh=u7xY3BtTj1nz8GHWAGlaymOYg+v++z7ZwIPBzcGw3c8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P9xx3cK69sNHo5a8zdwE+wl7MPpEMsYDT1I5CTKfuy2aOZ3u1tqpRiacpp9/nACWvdoqJ5trPTX0NhOmVCIUmSutuN+TRPRYqp/6Wq7w5/WYW0eqHeA17KqGLVJmbb74DZvrJVyNzaQNaUw5Ys6f2gUHHTmUP9+Ul+nDe4D2GBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JvpIPEWP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Qqq6j84p; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JvpIPEWP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Qqq6j84p" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E66CrB1688618 for ; Wed, 14 Jan 2026 07:26:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dBtKhiSX+0Upq4Tgz55RdSfcY3zlhvYInSL7xhV1iQ4=; b=JvpIPEWPmKIbbjYP dMCqvPHtQxPB5m+DnH6d47iHnP7rXqa3S+0H8aF3sgJSArdc4BMR78dIVHwMvv0G j8CFPX4ylKHv+fucr32NkfgSw//a9ciHgPSVCD2bbcE17TCab8+yGDh+G9pmZ35p +oN6RrQbjtzJu1lecBzc2S4Zk9cxt74hBV3dRrf8bR5gwSHYp1n1QJF8IayAgQPw U3CM0JiS1Y3xRR6OkAFh+cxme84ddfRnk0YhU25fR1PtOtqm43yvG9aDCNt7QvXC rPCbtCBKzFk9yVPSjxRf/EhnQy6a8S2rDdO1pU6v1imGpk/BbCXAAdVhq5AMp6CC G+AZDQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnsybam02-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 07:26:57 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-81f39ad0d82so7007740b3a.3 for ; Tue, 13 Jan 2026 23:26:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768375617; x=1768980417; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dBtKhiSX+0Upq4Tgz55RdSfcY3zlhvYInSL7xhV1iQ4=; b=Qqq6j84pk3Zw9K4tX/O0mRoA3ApXvOk2/1Z+XlySsLlM2QVZyQVNeiH5tIgjq0uVoI gF/naPkoP0MiyI5WfjsH3rNdouPGrzL6y5zjS3gSLDuk+H4QFkDszeDr0hV2Xy6Az076 t5G8X8QLp9sRyUREce8ID3O8vxIsuNJTGaZX9O3y3D4IGcYuzfN73Yc0pINmt9glpaNt 7yEoYAfsUrsRF//rl+B2NNJ3TzGHARpHn6SxGNcbH7ew3NSGqkrpc9SVuW9Oi/9gywkv 9Qt1LA+7sxoFErZdETpSi8izSzfFer9KytgKxr9Cn3SQHZj4ljTihox5wtgl/+GfgauN Lfyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768375617; x=1768980417; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dBtKhiSX+0Upq4Tgz55RdSfcY3zlhvYInSL7xhV1iQ4=; b=n3PS8D/gqhaU6It4jTSbc4egInefPFT9VgTTCXrrZApzqt1USz3dEHf0QIlvRMrAI2 M2WUs+eN3e0oX/3NtxtXzwOorKRHrVnJ+8Wu54jMgOHs/iil4Hr6FGVWRHKpUOL68It/ bFTGi1VKoLEw62Hgf1kMRNWuqJTztCydq2kCnqHf+nTJMmBnNZRtR2/hkQgeFabdHAWj lYX5HUqd84OT8nS4aS6J4LyJARurg4/mXPwbZj1HH6exA7QAO6dA+cbp3LnzfSWCAbsJ 7IsCOjbyVUTpHIwxKbw/lhI1j9UK0hUigtZU5LA9b0BhBjof50BDqX0tk5N6yVXE9atO JlEg== X-Forwarded-Encrypted: i=1; AJvYcCW02w6K8qKAivtfcMuKk1ZJN5No110ezxy+08j6oVlxNxJFaJ8T8oalThU3zBbM1M8xnGineGL/61wd2Ds=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4aoiF/nQX70AkaDFPmJzwpCpST1MXFygaJxDRbjoMDyP38TbL G34oRAI6FFJpHu1NqvTHrLzpwi2MVh+VjBJHQ2ftfeBnDWFBlyLfXIxUrqi3cgeSgB9yWQ+SMz8 FKCUigx8yzWWHs3kiQKngi+gODyrRRkgCPV4ycPOaMsTlEddHR4ViN3fX1lscbGLRdLM= X-Gm-Gg: AY/fxX6qO20iZgbLsQEnREJ7RQlrzWYvvoeGBXFtECy11MvnPtZvuvmPhbSPMfqJyOl Z4od1DlxFogKsQ2wtU92M6M7kH5qR+EFyi3T85e5tp2Zjt/RGaUVKRDnsE//AzrHgDvT9LVZ3w+ tF/7aZxWvWAAF1fFTkVk31gDZJWLUH1m4rGiTUY8OZ4y5oidYDhYdYSjFjeosZFqpoqv1Ki83IA croarThSgsmQ6WWKa6Op+TUE10rJfLWpbsywPuciV6cWlbm6OrTBCZG+LvoMQuNpikCwXjSFwuK Zd8koT9eT30TpuhIFYSirqQlo/B5exFiI1hQErPSNfXgX1LIAhMhpEiV1VKkfjPtSrQU9g4el7V /nkHKME0w6q6QnkyusTts9vGPeSPonr+VY39X3jfJETS5 X-Received: by 2002:a05:6a00:909d:b0:7e8:4433:8fb0 with SMTP id d2e1a72fcca58-81f83d5e569mr1170871b3a.56.1768375616697; Tue, 13 Jan 2026 23:26:56 -0800 (PST) X-Received: by 2002:a05:6a00:909d:b0:7e8:4433:8fb0 with SMTP id d2e1a72fcca58-81f83d5e569mr1170836b3a.56.1768375616238; Tue, 13 Jan 2026 23:26:56 -0800 (PST) Received: from [10.206.109.90] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81f87aa4f97sm250194b3a.69.2026.01.13.23.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 23:26:55 -0800 (PST) Message-ID: <57f3bfed-61e2-3e6e-c7f1-8f1ad69fea94@oss.qualcomm.com> Date: Wed, 14 Jan 2026 12:56:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 05/11] media: iris: don't specify highest_bank_bit in the source code Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Bryan O'Donoghue References: <20260113-iris-ubwc-v2-0-4346a6ef07a9@oss.qualcomm.com> <20260113-iris-ubwc-v2-5-4346a6ef07a9@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260113-iris-ubwc-v2-5-4346a6ef07a9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 0NDfftuvRLU8AG0nl1Bwg2ghFAK_yS7W X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDA1NyBTYWx0ZWRfX5+K1Jk2inBqi V6uZnqg4EIFWqnG14D19P2L0rjPWYtGDdOIbK1oY4Fqad5+G4KHTxmrWDJOQevaO7Tpkpd59owc F5aHrhscVBhdZnrVdQ+CtT13mvfpLr3eocHox2shCb/7gHZkLS4O1Ep1O3SjDWkR2JyicrohS2b UQ2LJvPLZzjAeD9PoB2PTnSRx4u302OpP+1lGuKDUchdDKB/t4RCEW9g17rQ+cwpKP97ES9s0pk E4KmwsftSyXmHJaLf4zQ1SS2WZByZk877o9Vpu9CBRXmjWn98HuLPtoL23KfUH/c7pCSJeT5p4d AIbYG4slxCPb0cik3GTektNPGzJXUwqNphJripx1xqCCpuQmK9W0PQgMem9FsFz8fCiU8N0pEPE WHCNoTXIh0ldZBOepO/11ZclEFl9ikmZzh5eVGBWElOELt+hSEn7F9CfPl4yIjhuOLN2owsIe7N 9dG87SAgh5A2vXz/X/A== X-Proofpoint-GUID: 0NDfftuvRLU8AG0nl1Bwg2ghFAK_yS7W X-Authority-Analysis: v=2.4 cv=IpETsb/g c=1 sm=1 tr=0 ts=69674541 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=yL4243FK61EKG2Nsi2QA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_02,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140057 On 1/13/2026 10:27 PM, Dmitry Baryshkov wrote: > The highest_bank_bit param is specified both in the Iris driver and in > the platform UBWC config. Use the platform UBWC configuration instead of > specifying it directly in the source. > > Reviewed-by: Konrad Dybcio > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c | 2 +- > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 1 - > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > index 878e61aa77c3..a4e60e9d32a4 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > @@ -159,7 +159,7 @@ void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_heade > &payload, > sizeof(u32)); > > - payload = core->iris_platform_data->ubwc_config->highest_bank_bit; > + payload = ubwc->highest_bank_bit; > iris_hfi_gen2_create_packet(hdr, > HFI_PROP_UBWC_HBB, > HFI_HOST_FLAGS_NONE, > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index 3c5f3f68b722..8421711dbe60 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -73,7 +73,6 @@ struct tz_cp_config { > > struct ubwc_config_data { > u32 max_channels; > - u32 highest_bank_bit; > u32 bank_swzl_level; > u32 bank_swz2_level; > u32 bank_swz3_level; > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index c70cfc2fc553..5ae996d19ffd 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -633,7 +633,6 @@ static const struct platform_clk_data sm8550_clk_table[] = { > > static struct ubwc_config_data ubwc_config_sm8550 = { > .max_channels = 8, > - .highest_bank_bit = 16, > .bank_swzl_level = 0, > .bank_swz2_level = 1, > .bank_swz3_level = 1, > Reviewed-by: Dikshita Agarwal Thanks, Dikshita