From: Guenter Roeck <linux@roeck-us.net>
To: Eliav Farber <farbere@amazon.com>,
jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com,
sudipm.mukherjee@gmail.com
Cc: hhhawa@amazon.com, jonnyc@amazon.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] hwmon: (mr75203) fix undefined reference to `__divdi3'
Date: Wed, 21 Sep 2022 07:02:27 -0700 [thread overview]
Message-ID: <57f5b28d-3a21-3d1e-422d-d79eebefb8e5@roeck-us.net> (raw)
In-Reply-To: <20220921121723.6726-1-farbere@amazon.com>
On 9/21/22 05:17, Eliav Farber wrote:
> Fix build error on 32-bit machines.
>
> Fixes: 381a86c545f1 ("hwmon: (mr75203) modify the temperature equation according to series 5 datasheet")
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> Reported-by: kernel test robot <lkp@intel.com>
Applied.
> ---
> I will also rework it into the original series (since it's not just a
> trivial squash into one previous commit) and you can decide what to use
> according to your preference.
>
I rather keep this patch separate.
Thanks,
Guenter
> drivers/hwmon/mr75203.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 0fea443dc3e1..9c400cf790b5 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -266,9 +266,9 @@ static long pvt_calc_temp(struct pvt_device *pvt, u32 nbs)
> struct temp_coeff *ts_coeff = &pvt->ts_coeff;
>
> s64 tmp = ts_coeff->g +
> - ts_coeff->h * (s64)nbs / ts_coeff->cal5 -
> + div_s64(ts_coeff->h * (s64)nbs, ts_coeff->cal5) -
> ts_coeff->h / 2 +
> - ts_coeff->j * (s64)pvt->ip_freq / HZ_PER_MHZ;
> + div_s64(ts_coeff->j * (s64)pvt->ip_freq, HZ_PER_MHZ);
>
> return clamp_val(tmp, PVT_TEMP_MIN_mC, PVT_TEMP_MAX_mC);
> }
prev parent reply other threads:[~2022-09-21 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 12:17 Eliav Farber
2022-09-21 12:45 ` Sudip Mukherjee
2022-09-21 14:02 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57f5b28d-3a21-3d1e-422d-d79eebefb8e5@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@intel.com \
--cc=farbere@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jdelvare@suse.com \
--cc=jonnyc@amazon.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®