From: Colin Ian King <colin.king@canonical.com>
To: Alan Tull <atull@kernel.org>, Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: mgr: altera-ps-spi: make array dummy static, shrinks object size
Date: Thu, 24 Jan 2019 16:49:04 +0000 [thread overview]
Message-ID: <580295c8-9779-3246-fced-1538b9e66f68@canonical.com> (raw)
In-Reply-To: <20181129231016.4580-1-colin.king@canonical.com>
ping?
On 29/11/2018 23:10, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array dummy on the stack but instead
> make it static. Makes the object code smaller by 26 bytes:
>
> Before:
> text data bss dec hex filename
> 7371 2032 0 9403 24bb drivers/fpga/altera-ps-spi.o
>
> After:
> text data bss dec hex filename
> 7281 2096 0 9377 24a1 drivers/fpga/altera-ps-spi.o
>
> (gcc version 8.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/fpga/altera-ps-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
> index 8c18beec6b57..678d0115f840 100644
> --- a/drivers/fpga/altera-ps-spi.c
> +++ b/drivers/fpga/altera-ps-spi.c
> @@ -205,7 +205,7 @@ static int altera_ps_write_complete(struct fpga_manager *mgr,
> struct fpga_image_info *info)
> {
> struct altera_ps_conf *conf = mgr->priv;
> - const char dummy[] = {0};
> + static const char dummy[] = {0};
> int ret;
>
> if (gpiod_get_value_cansleep(conf->status)) {
>
next prev parent reply other threads:[~2019-01-24 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 23:10 Colin King
2019-01-24 16:49 ` Colin Ian King [this message]
2019-01-24 17:16 ` Alan Tull
2019-01-24 17:22 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580295c8-9779-3246-fced-1538b9e66f68@canonical.com \
--to=colin.king@canonical.com \
--cc=atull@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®