From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
martyn.welch@collabora.co.uk,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>,
Kevin Hilman <khilman@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no callbacks
Date: Mon, 05 Oct 2015 15:29:59 +0200 [thread overview]
Message-ID: <5808910.FQ4CPUCAtb@vostro.rjw.lan> (raw)
In-Reply-To: <20151005090727.GA24851@xo-6d-61-c0.localdomain>
On Monday, October 05, 2015 11:07:27 AM Pavel Machek wrote:
> On Mon 2015-10-05 10:25:45, Tomeu Vizoso wrote:
> > On 4 October 2015 at 17:16, Pavel Machek <pavel@ucw.cz> wrote:
> > > On Tue 2015-09-29 14:29:19, Tomeu Vizoso wrote:
> > >> If a suitable prepare callback cannot be found for a given device and
> > >> its driver has no PM callbacks at all, assume that it can go direct to
> > >> complete when the system goes to sleep.
> > >>
> > >> The reason for this is that there's lots of devices in a system that do
> > >> no PM at all and there's no reason for them to prevent their ancestors
> > >> to do direct_complete if they can support it.
> > >
> > > Dunno. This sounds like asking for trouble. Even if most devices can handle
> > > this, is not this bound to introduce some bugs?
> >
> > Hi Pavel,
> >
> > in which situations do you think that this could be problematic?
>
> Well.. driver with no PM callbacks probably works "by accident",
How exactly?
Do you have at least one example of that?
Thanks,
Rafael
next prev parent reply other threads:[~2015-10-05 13:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 12:29 [PATCH v5 0/2] Tomeu Vizoso
2015-09-29 12:29 ` [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no callbacks Tomeu Vizoso
2015-09-29 13:37 ` kbuild test robot
2015-09-29 13:38 ` kbuild test robot
2015-09-29 13:39 ` kbuild test robot
2015-09-29 14:39 ` Alan Stern
2015-10-04 15:16 ` Pavel Machek
2015-10-05 8:25 ` Tomeu Vizoso
2015-10-05 9:07 ` Pavel Machek
2015-10-05 13:29 ` Rafael J. Wysocki [this message]
2015-09-29 12:29 ` [PATCH v5 2/2] USB / PM: Allow USB devices to remain runtime-suspended when sleeping Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5808910.FQ4CPUCAtb@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=martyn.welch@collabora.co.uk \
--cc=pavel@ucw.cz \
--cc=stern@rowland.harvard.edu \
--cc=tomeu.vizoso@collabora.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome