Re: [PATCH V1] accel/amdxdna: Check drmm_mutex_init() return value

[Max Zhen <max.zhen@amd.com>]

On 7/7/2026 Tue 10:23, Lizhi Hou wrote:
> drmm_mutex_init() may fail and return an error. Check the return value
> and abort initialization if mutex creation fails.
> 
> Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Max Zhen <max.zhen@amd.com>
> ---
>   drivers/accel/amdxdna/amdxdna_pci_drv.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/accel/amdxdna/amdxdna_pci_drv.c b/drivers/accel/amdxdna/amdxdna_pci_drv.c
> index e94d8290a807..86e9c230875a 100644
> --- a/drivers/accel/amdxdna/amdxdna_pci_drv.c
> +++ b/drivers/accel/amdxdna/amdxdna_pci_drv.c
> @@ -373,7 +373,10 @@ static int amdxdna_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>   	if (ret)
>   		return ret;
>   
> -	drmm_mutex_init(ddev, &xdna->dev_lock);
> +	ret = drmm_mutex_init(ddev, &xdna->dev_lock);
> +	if (ret)
> +		return ret;
> +
>   	init_rwsem(&xdna->notifier_lock);
>   	INIT_LIST_HEAD(&xdna->client_list);
>   	pci_set_drvdata(pdev, xdna);