From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 071E2C433E7 for ; Thu, 8 Oct 2020 07:49:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A936E21924 for ; Thu, 8 Oct 2020 07:49:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727689AbgJHHt5 (ORCPT ); Thu, 8 Oct 2020 03:49:57 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:57596 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbgJHHt5 (ORCPT ); Thu, 8 Oct 2020 03:49:57 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 334FB28DBF3 Subject: Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers To: Chun-Kuang Hu Cc: linux-kernel , Collabora Kernel ML , Yongqiang Niu , Matthias Brugger , Nicolas Boichat , Hsin-Yi Wang , CK Hu , Linux ARM , "moderated list:ARM/Mediatek SoC support" References: <20201006193320.405529-1-enric.balletbo@collabora.com> <20201006193320.405529-5-enric.balletbo@collabora.com> From: Enric Balletbo i Serra Message-ID: <580ecdf4-a686-f14c-a230-7f87f0c8cde5@collabora.com> Date: Thu, 8 Oct 2020 09:49:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chun-Kuang, On 8/10/20 2:01, Chun-Kuang Hu wrote: > Hi, Enric: > > Enric Balletbo i Serra 於 2020年10月7日 週三 上午3:33寫道： >> >> From: CK Hu >> >> Actually, setting the registers for routing, use multiple 'if-else' for different >> routes, but this code would be more and more complicated while we >> support more and more SoCs. Change that and use a table per SoC so the >> code will be more portable and clear. >> >> Signed-off-by: CK Hu >> Signed-off-by: Enric Balletbo i Serra >> --- >> >> drivers/soc/mediatek/mtk-mmsys.c | 393 +++++++++++++++++-------------- >> 1 file changed, 210 insertions(+), 183 deletions(-) >> > > [snip] > >> >> static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = { >> @@ -93,10 +115,6 @@ static const struct mtk_mmsys_driver_data mt6797_mmsys_driver_data = { >> .clk_driver = "clk-mt6797-mm", >> }; >> >> -static const struct mtk_mmsys_driver_data mt8173_mmsys_driver_data = { >> - .clk_driver = "clk-mt8173-mm", >> -}; >> - >> static const struct mtk_mmsys_driver_data mt8183_mmsys_driver_data = { >> .clk_driver = "clk-mt8183-mm", >> }; >> @@ -106,180 +124,192 @@ struct mtk_mmsys { >> const struct mtk_mmsys_driver_data *data; >> }; >> > > [snip] > >> +static const struct mtk_mmsys_driver_data mt8173_mmsys_driver_data = { >> + .clk_driver = "clk-mt8173-mm", >> + .routes = mt8173_mmsys_routing_table, >> + .num_routes = ARRAY_SIZE(mt8173_mmsys_routing_table), >> +}; >> > > I remove my Reviewed-by tag. You does not set routes for mt2701 and > mt2712, but these two SoC need that. Maybe now they use the same table > as mt8173. > I did that on purpose as explained in the cover letter, and asked for someone with the hardware to provide me a working routing table. But, if you think the same routing should work on those devices I'm fine to use the same for all the current devices. I don't have that hardware, so anyway, will need to test. Thanks, Enric > Regards, > Chun-Kuang. >