From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 670BD335BBB for ; Thu, 7 May 2026 14:57:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165832; cv=none; b=Xc6R/2tU5MUf7pmsEfcsFxANRXBNBjjTZHkd+XN5TKjngULw51FECAqK3mGiGorh4upaM5UPMy4WePkcFzvGrG0qQl+tJ4mVXKkaJEzc6SsivPvM5on/PCeNLyrAN8G4tu1rTtfCF/dImXOBOl+CtGbwAAkAiOyDFE1mAHbIWiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165832; c=relaxed/simple; bh=DayezZOFHOXdCArrfetArsHplkxt+a71ssRuUgTFiAo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nJ/bgaRR3ZP0JMcWpHP1DR1Apa8DTD2qc5g4TXUaZ4aDerXuRrfIsXd8Fj5MRvz2uWUR51/cDyhaws+f0qnO0mirnOzkETETdNYzuZhJcv8p44cr1OoiUe9b6WVsjE1iBt3bB7T2tLh+1UJWuAwPv+e6jhZhUSWXk/yl8tmhFSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IKvZO0E0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aj2uiZff; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IKvZO0E0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aj2uiZff" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647Bxa542734190 for ; Thu, 7 May 2026 14:57:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4npxAss+cBkEEkowA0VPvewqjM3l+sBKHX3dTsvFTvA=; b=IKvZO0E0r2pupgEl 87XJIk8uojF4AcTI1foHZax3+hTAnQAzOH19HwAJsU/VmHevm8oE4Tn3vmJ2RSgq fYxRzW1JHA/c44O3gK0nrJc6/3iwygll9fXpsSqqiN8aKHFwfbE5kO3DbxfW4ifi sV2r/XhPWEC+HNdPzT692Ih+lxEhEHmVDK2SRRyHVL4I6UOm5XrY9E3UQcC0EWEk n/ATea9ikR94ynTW8DvwQN5+bzNECxwpcmFmxa87EsgHDYQPLMIK+2nTjsMxiYeh kLpIJfBl7RrrFfUQWC/niCOhnVMxozvM+IsQuRwFW/ZbeBJHhcMxdX176R0car2C 7RwnTA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0tbqrpaj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 14:57:10 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b9b8137828so10718665ad.0 for ; Thu, 07 May 2026 07:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778165830; x=1778770630; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4npxAss+cBkEEkowA0VPvewqjM3l+sBKHX3dTsvFTvA=; b=aj2uiZffi0bcNBYEf/1wcSfHbd1MSCVTaQpnmPC/OWSfUpOLF9P9Y/xYYMbfMoe4Hx QHO6Md3+0Qg4HnPHC/8EiYLI140WiZSP20GCntIimPmAN0uRD1QIlEOpJlCT1vzTtRzB xl+47rN/6s0cgInMVwIvVVM3amYLOBY7pPwAur6v+dOqNpUSKzFbPcmX/qFPGoWrNl/T cs3+8J4N/11egAfmc1ZGB+NAQxMvyPxx/cmQ93tuYDK08oBfEi06/ac+KiXDw6Yz2T3A l2k4dZ2UnPAs1t53YMpKvw17PON31q4qCQb/pcaxHg27ju4Dvo38PMLC3eIhO1uuGDqU xnFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778165830; x=1778770630; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4npxAss+cBkEEkowA0VPvewqjM3l+sBKHX3dTsvFTvA=; b=qMidJ2xCA0LuJNXFnILnipuKE3SwOf2wGoq8Cwc9uExr/UXWL1sqR49GGUNvYxrUM4 tIlCC+rlE6PvgYhU5bOLwain1/WdB0jF9s+zGhfDB0Jne54VX1TcYoLLIBMJP+LZwTk9 HdpMWWStDPTDysxziWrgyd/hPzcYfyuh1MUVWA7zhe7NzCxKvaHEBxwMx5aqjHFGzUdQ nVxEHRxa/ns27Rj2fj4HFrSBwn/dvVS4SuCTiB2d2ATOQPJodtPwSuvs6VY6X9DsDXNC EfdCdDdoDLKfZ5AioxFTnFGZDdJF7iyfHMtVG1PXpHP+ZWLj4BmTq0yupM9NBHv5PhR/ kWpQ== X-Forwarded-Encrypted: i=1; AFNElJ91s78wDv3SmZ9mcrQxvVvrmDlTuLP8BQHxHyK7YQQXCsQIkuSoQu5N6p1VC25cyOAt9q6q9578T4iWWn0=@vger.kernel.org X-Gm-Message-State: AOJu0Yytgj+PXzeHl8E215Dc0lBEtZGmRuVWqgQ35zvWg5vqUgTyDyN5 Hroc1VQjzF4qA062MK2y8go8dvZchzz7WzTvNUhX/Xy8wzUYg+OT9/DxXhZ3XximctA6Bgp6Ltw 6M7iSMP5NqidDWh0GyFyjE0dlgxC8vSCkrJdaDLopCk+Cf8zd7FGdE2IRcB2qxb9iLmc= X-Gm-Gg: AeBDieszprhq2FW6YrlVJ9wLsnhxu6QxZCSsfIrCkZxrKWFvq+8kkdgKhKAXUMUl6uu I/REoOe1mlv35iQCRS6znRkMuU4vYYDsgzTGFots7R7F7JLhMZeQ9ohjswZuTNFux3ZBhjgUK7T iRoY24eLBaBvNy/NJFE7s6gqTyHzojvd3m4/gmrJVzHx8EQKIjs7Db2+ubnqNdxO0UozBmoprpb ucN4w3jBQJqFRtM77KSQey4LCwnMWS2/L+6N38jvRHJe9o3e6WxVi5KupyHP7UFd5xn88fubp5+ fbFoJB1dt+np3gZAKPcwv2L1oAYsQxKQktKO8dp7h9DhYQglGKPLAteHtOoyECbdZHPkGkEW1Jq ktBMDlQ5ejFElXy4zxEn2Zs2825mIn2ygTawYUR8VgntVoR4LEHlpQDc= X-Received: by 2002:a17:903:3201:b0:2b2:9f9f:fe6b with SMTP id d9443c01a7336-2ba79bda3e7mr81185555ad.40.1778165829777; Thu, 07 May 2026 07:57:09 -0700 (PDT) X-Received: by 2002:a17:903:3201:b0:2b2:9f9f:fe6b with SMTP id d9443c01a7336-2ba79bda3e7mr81185225ad.40.1778165829268; Thu, 07 May 2026 07:57:09 -0700 (PDT) Received: from [10.206.103.12] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2babadee7c8sm27872465ad.57.2026.05.07.07.57.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 07:57:08 -0700 (PDT) Message-ID: <581743f9-6385-4803-a91e-0b7d38fa6a17@oss.qualcomm.com> Date: Thu, 7 May 2026 20:27:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 19/29] drm/msm/adreno: use version ranges in A8xx UBWC code To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> <20260507-ubwc-rework-v4-19-c19593d20c1d@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <20260507-ubwc-rework-v4-19-c19593d20c1d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: NrwMYr4YZg02G54eEozQsNeO-pnzDWQ8 X-Authority-Analysis: v=2.4 cv=SJVykuvH c=1 sm=1 tr=0 ts=69fca846 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=F66dyu4Cpv24ktMMw0UA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: NrwMYr4YZg02G54eEozQsNeO-pnzDWQ8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDE1MCBTYWx0ZWRfX4che+ll4mc1C jHx2fSbkrGF9WmQKN6VquQRGxdWBo8jqZGCGwlgcqCi2CB55yjWKQnI/BypIFc5Ebk6kBSxl1yK OHEU/yFGLQ87jOsAU0qHUI2lwAwDA/G4EVNAO5jJx0prBjZKv7cTcdrAgv5kYIpiA4xzep602hg xJjlmlVrKKXuZAl40aOd1D3IsiaqaCsdJbEYLl88AaDPwLcjcM4MF+GJho5IXNel1yNxTFhSAYT aG1N2byJeH73490Oh5ynH/0k8k46hinK/hwTrEkEqyJXmoo7kTepm8RJKOozRqUk9wLyrr+HCgA u0RWwQ+7GcHeq8irV7B5xeBkfHfJWf2kOyRREFHRRJnixhQ8qvhDOih4Q6+8+rh++t1HAOdQi77 gwhoHLCb2USOJfM3Qa77xKtdKcLLr/km4da/pa3JRcfMDDPo6/ZGdYpuM4VKhDM26HVg25OULUl zCkUairANvpfQGiAcaA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070150 On 5/7/2026 6:33 PM, Dmitry Baryshkov wrote: > In order to simplify handling of UBWC minor revisions (like 3.1 or 4.3) > use version ranges instead of a case switch. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen -Akhil > --- > drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 32 +++++++++++++++----------------- > 1 file changed, 15 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > index 5c73a9ebb22b..29d559fe4683 100644 > --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > @@ -286,26 +286,24 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) > u32 hbb, hbb_hi, hbb_lo, mode; > u8 uavflagprd_inv = 2; > > - switch (ubwc_version) { > - case UBWC_6_0: > + if (ubwc_version > UBWC_6_0) > + dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); > + > + if (ubwc_version == UBWC_6_0) > yuvnotcomptofc = true; > - rgb565_predicator = true; > - break; > - case UBWC_5_0: > - rgb565_predicator = true; > - break; > - case UBWC_4_0: > - rgb565_predicator = true; > - fp16compoptdis = true; > + > + if (ubwc_version < UBWC_5_0 && > + ubwc_version >= UBWC_4_0) > rgba8888_lossless = true; > - break; > - case UBWC_3_0: > + > + if (ubwc_version < UBWC_4_3) > fp16compoptdis = true; > - break; > - default: > - dev_err(&gpu->pdev->dev, "Unknown UBWC version: 0x%x\n", ubwc_version); > - break; > - } > + > + if (cfg->ubwc_enc_version >= UBWC_4_0) > + rgb565_predicator = true; > + > + if (ubwc_version < UBWC_3_0) > + dev_err(&gpu->pdev->dev, "Unsupported UBWC version: 0x%x\n", ubwc_version); > > mode = qcom_ubwc_version_tag(cfg); > >