From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEE2F369972 for ; Tue, 13 Jan 2026 07:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768289021; cv=none; b=i8HYon/qlz4XzI/+NyLdcKzOLykTfX/JF1OnzLs5eEKDEXQICapXH2UIOZCDOQPyWLu4hKf9Rwc3SHnfPGzsCXh/T+uAouUp5LZnCcwQ6Hud1+CyY4m8a45zrXXC4MdxWnsovxoSkRUCEp8tj5SkGCxEItazUwjQu8lN0UBxs2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768289021; c=relaxed/simple; bh=RX4UBOE9tCTa0FI3pKdIvODZ1uSshGHS7PWPsy046Vo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JIy7Ksm22RXE0QLjsRLHYCgT45nb2Cl27/evMeLI6ty3B+yo58OFLWgpZmG3wRamQBhoH7INIsQ/22dyERqNyEsZWfW+ePNMq5li4Opae8xDGjW1z4qR6ciMtIYtwRWYwQhj9K0lQ5o62xAkZfWf7BQ/6WjnHstSPPYGlVv//jI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=O8Y91ILd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Wr0QUJd4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="O8Y91ILd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Wr0QUJd4" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D5nUdx3735127 for ; Tue, 13 Jan 2026 07:23:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oNgFazqcMlu8myL+AuN/JIcSjpDYbPE9dhbXciQk9os=; b=O8Y91ILdxqEvLqd4 nqY0Nno8epFqtZnfnCRAPOEvBD04AcvdxfwnDX09TL74yJmC26PHuc2jmToWsCM+ MZBdhtFa9ioLHKDcxfZs0O1s8VLhRcjYK/UNJ2pi+5NN8anfPQJu/TEzpNY9qze5 vOhhKCGN6KkBobCL1j5uKitDBdsAekEKmQeXJRoGy0O/YTJqk3jKu35NCWTd9mXR R8rVqEQtJsdaeRqVa2nOZ56yCe9C6TMzF0CF/pOFEg4XoNI9RP+gUakbFBvgbId0 jYbas+YmNu44/2XGJe/VgPrS+tQbjhJ4wBL3nfVXNG5w9kq6hYdMRJ5X00uA2/VL RWThdg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bng8787xs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 07:23:38 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-29f27176aa7so107879805ad.2 for ; Mon, 12 Jan 2026 23:23:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768289018; x=1768893818; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oNgFazqcMlu8myL+AuN/JIcSjpDYbPE9dhbXciQk9os=; b=Wr0QUJd4uFkIjXfoysb+/ZLJgZrXTiFkKoQjxqv5KNXHjZN5KiO8gpmpUfddjHtQeg mwWLCAn4lUPT5p/+AcBctqlJtk0WhO5k8ZeLY9PqOMzmAJX1cL2pVbRHuf1pfludl1qB T6Q8PSrGkGHTr97iLe7NFaZnQ5YvcnoPfGYni6MlRhzM27HqD0zj5vZlewtyzMn8TN1A 9B67qOQ2ZLCZrwI98CFpKPr++EEgBhpej4L9HQ2k/pZBOYd60NVp9/0hkyUWLyrFU7Ri AVjSXEHkOXqjjrcmkShVNsxYQix1t9nWJ7q1mT6sx9CdprfFLpk6UIzTSxt94kwMQBwg bmjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768289018; x=1768893818; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oNgFazqcMlu8myL+AuN/JIcSjpDYbPE9dhbXciQk9os=; b=GoH1qmv+vSyQU3c03ReybgSZeJ4Ato9YSzQAEq8VZBmCOl1ytmcgTkkmqlpHZOMQJ7 zrLCQ2skfwCvo10t3NDzdDPlwrjnF8LTwGU/1+NdiZsUQ18WkfPzjTMkb1JfUj/dRXqz O8UYYUm9yWHuP+mB367abzPDPa2SSF3OqJxtJnqe5689N/0jCufEiDAcivqWe+VkVqTl sqMwCoEEqdMO3xgwm21n5wYHeg3EIXKON1ZjBIUv338i1eWQImRdmGblc8T8QHpmdrg5 HKWHaJ5aIo7tF1iF/Y2kjnXjzvRv6LGyK/KM7AOmN31c3hVtYYY7kRACArk44Wlh2AVG Fovw== X-Forwarded-Encrypted: i=1; AJvYcCXgkgIftUw6sSetXNnX1v7uQ2HKD/+5cx7Wr0wgNR+XHqHtQA1xeOx15LjwCJX8gqBAVbxeiBWQe9EbAlk=@vger.kernel.org X-Gm-Message-State: AOJu0YyPgwA4T2kY9KM0S0XIganbdAsRHum8Y1dj+b0DaZgmCg4mPRyb MhW+RUpzoAAvb9JWmtqLuyE89VM29BkdjaTGRhj7lzKLHjaJ31v1xuG6NiHe0RRS6Carkg+vVGZ XyI452o+18Z7R4dAEO2Cf/svFhHfwPPCjC//Z23yUqMQiGwT6rZzQSHMaRxcZi56dFMVy0Kgq18 ZNwQ== X-Gm-Gg: AY/fxX51RcxjQAQ0IRkUVEiIq73DPOp1hOiMR4sY+F+GhxcpkfhRiIz5MSltTEmr2Eb QJyB5/vZQrcblmMor9ZwJxWWbEEbjiotJ/WA77sOwZck1XSTyrleCijF5PFOe9w9UQ55dAveKoQ xnp7qyMB0+k7pu7H1A8HP1jcWkxrhnowNA3CapRZj823dR/KWpQwJaksW2fxFHkebwosA6ZCsQj 4isRf+jymuQRrGovVyYp8UcvyKMa+HiwTdW/jR3SXqzlIDKusCTj6lVjCJaKBimVwIRrSsxSN5l A9IXdgkvAlrIUICPen/3ucC8+IwhWpzecZjVkFcvRNlc0fL2JhEeFp+Ktw/rYdUs6AfbjLQvEuS EhlQfQw4+j3v32fF87SXhhcV5ONPP1IKzjFTr/AGDmuUgtGhu/VfgiLJ/ua7Y4jhhQRrqWx9It3 93z80= X-Received: by 2002:a17:903:1b0c:b0:2a2:caca:35d2 with SMTP id d9443c01a7336-2a3ee429933mr213782205ad.16.1768289017693; Mon, 12 Jan 2026 23:23:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHwDEFvz6AypcTbvFw5c0lu2Oo0n+YreDV6bmdNGs37euaqv+jPI2MpciMHjODGQ8L1iQ3/Nw== X-Received: by 2002:a17:903:1b0c:b0:2a2:caca:35d2 with SMTP id d9443c01a7336-2a3ee429933mr213781975ad.16.1768289017228; Mon, 12 Jan 2026 23:23:37 -0800 (PST) Received: from [10.133.33.201] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc8920sm191440495ad.85.2026.01.12.23.23.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 23:23:36 -0800 (PST) Message-ID: <581a9672-64b5-4df2-ac9d-bd3dbc1730e6@oss.qualcomm.com> Date: Tue, 13 Jan 2026 15:23:30 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100) To: Val Packett , Vinod Koul , Neil Armstrong , Abel Vesa , Dmitry Baryshkov Cc: Abel Vesa , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, yijie.yang@oss.qualcomm.com References: <20260111083317.604754-1-val@packett.cool> Content-Language: en-US From: Yijie Yang In-Reply-To: <20260111083317.604754-1-val@packett.cool> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDA2MCBTYWx0ZWRfXx2kBkOD8tPks jsdyoDIk+ds2Gzgb7oWbNkmtontkkpNe006tKK6rbSmK4alOe99eo2sN6hqSEJs3fQlhx5GoerF XAqDGCdoIoUOSOVIQ7cSY0PH326bT8pmFR9qWHsTlLfoBWTU2tX/Vp3bImTrjXHspafO+d7pr48 WfIK1/3ziMnoXfual5rvMG3b6rYgyuK5YUtFnQzv/WfJzTlSWgpTXKSF8as2vT+Y+4y8r2/sK+y zb4WlXeaNHCCmI16PNX+GdGjDurxaFwD/pX1PRTA0n4nbGyM2rs4g96BNQVPCAZaDCrn4M8Ufmd Sj1Af9v582uhkoiMwL7JChMEztcT/uzPpTBfMie2ftBJSGxHhydtCtEZKFeaHKxPAWCjUnzn3W/ TJAK9pMiuMRw15u1S/bNXYlqEFzS4Y2t8lJvKpZ+ha3cDRNcAqg06aEzyveq3q8ngsK7tye/l36 J57Mm7GdjcXzWMl0C1w== X-Proofpoint-ORIG-GUID: rD9vVkhRCRzWQKBgY6ZjpxURVD3fi314 X-Authority-Analysis: v=2.4 cv=IOEPywvG c=1 sm=1 tr=0 ts=6965f2fa cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=nuEKUdX3l-reoJBA14YA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: rD9vVkhRCRzWQKBgY6ZjpxURVD3fi314 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_01,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130060 On 1/11/2026 4:25 PM, Val Packett wrote: > For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a > stub implementation was added for the v4 of the hardware. However it > was omitted for the v6, causing a NULL pointer dereference oops on > Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub. > > Fixes: add66a6673bc ("phy: qcom: edp: Add Glymur platform support") > Reviewed-by: Abel Vesa > Signed-off-by: Val Packett > --- > v2: pull R-b, reuse v4 function as suggested by Konrad > v1: https://lore.kernel.org/all/20260109045214.5983-1-val@packett.cool/ > > drivers/phy/qualcomm/phy-qcom-edp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c > index 13feab99feec..7372de05a0b8 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -758,6 +758,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v6 = { > .com_power_on = qcom_edp_phy_power_on_v6, > .com_resetsm_cntrl = qcom_edp_phy_com_resetsm_cntrl_v6, > .com_bias_en_clkbuflr = qcom_edp_com_bias_en_clkbuflr_v6, > + .com_clk_fwd_cfg = qcom_edp_com_clk_fwd_cfg_v4, > .com_configure_pll = qcom_edp_com_configure_pll_v6, > .com_configure_ssc = qcom_edp_com_configure_ssc_v6, > }; Tested-by: Yijie Yang # Purwa-IoT-EVK -- Best Regards, Yijie