From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753562AbdAKJjn (ORCPT ); Wed, 11 Jan 2017 04:39:43 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:40300 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751572AbdAKJjk (ORCPT ); Wed, 11 Jan 2017 04:39:40 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f2-f790f6d000002555-8e-5875fd57afc7 Subject: Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board To: Inki Dae , Hoegeun Kwon , krzk@kernel.org, robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com, jh80.chung@samsung.com, andi.shyti@samsung.com, Hyungwon Hwang From: Andrzej Hajda Message-id: <581db2a8-e357-a3ba-9464-fa8f83f95c09@samsung.com> Date: Wed, 11 Jan 2017 10:39:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 In-reply-to: <5875EF69.1070803@samsung.com> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA01SS0wTURT1za9DcXAsoE9EiY0u0IASXEyUVIksJuhCVzSYCA1MWmJbSIeC GBeEBfIJf1BAArjgY1mAhVAEIlCwBdECCgEl8gkKKCKEPyQUaQcSdue8c887OTeXRCWduBcZ o43ndFqFWkqIsWbLts0vbFcvv1ZZEMBk2foQxtQzizOja3M4U9Fjw5nh9SWCWarJIJiq4myc yZ/MxZixnVScyZlZQJmBgQYR87W1jGCKB94jzF57i4jZbi3Hbp9g35X+ELFGQzrBmjamcHYy 04qw2U0GwK4az98nwsVB0Zw6JoHTXZVFilUthjw0zuD2xDZeJ0oGM64ZwIWE9HXYXtiGC/gU HJyoJzKAmJTQVQB+/z0PBLIKYO+WXXTo+JuXgglCNYDTNRbgECj6JNwqmMAcGKV94fxavhNL 6FkASxbvObA7HQVHnmc5zR50A4CL0/W4g6D0JoA5/2qdEcS+e7fxGyH8KoOfpkcQB8boS3D2 bYdzxpOWQ7NlHHVgF/oKTMksIIRkH9g1POdMgPSiCFZ/3twfIvfJOWjsRIUKIdA0/POgtDv8 Y206qOYN09O6EMGbCeBKTq9IIIUA2peLD9w3Ybd1CBfS3GB+88uDAAqmpUqEERaWdA9hwnMw bEn1E9ZVj8CxvGQkF/iUHtlY6ZGNlR7pUAlQA/Dg9LxGyfGB/rxCw+u1Sv+oWI0R7N9Vv926 0gLWe2+YAU0C6XFqaj5eLsEVCXySxgwgiUo9KPOWXi6hohVJTzldbIROr+Z4MzhLYtLTVHvl cJiEViriucccF8fpDlWEdPFKBtrE7r42YvRVnaopOGRnKcLf8Cx0bXOiUvYl8GFDfVyVl9HV M2bMdkveVyTreB0wtL4csBCq2ii7E16oqcrRfIg8tmtHKZxYkrhbMhsjiir8yilTds0Dvbdv R49U/ejF4C/Dma4EVmlNNKZk1TZeDFr0uTDX+zGy1bZ3t//NiBTjVYqAy6iOV/wHj97+r1MD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsVy+t/xy7rdf0sjDNo+8Vn0njvJZLH9yDNW i+tfnrNazD9yjtXiytf3bBbvl3exWSyd0cdqMen+BBaLG7/aWC36H79mtjh/fgO7xeVdc9gs Zpzfx2Txf88Odoufu+axOPB77Jx1l91j06pONo/t3x6wetzvPs7k0bdlFaPH501yAWxRbjYZ qYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W0rdL cMvYsWoic8Eqvopzt1ezNzA+5u5i5OSQEDCReDOxiQXCFpO4cG89WxcjF4eQwBJGifsTdrKC JHgFBCV+TL4HVMTBwSygLjFlSi5EzTNGiQvH54I1CwskSxxdNx/MFhHYwCjRcLEYomg9k8TJ Sx9ZQRxmge+MEsf2/AOrYhPQlPi7+SYbxAY7iTMPrzKB2CwCqhLPNu5nB9kmKhAh0XA4HSTM KaAt0dQ9GaycWUBe4uCV5ywTGAVmIblvFsJ9s5BULWBkXsUoklpanJueW2yoV5yYW1yal66X nJ+7iREYtduO/dy8g/HSxuBDjAIcjEo8vA9elEQIsSaWFVfmHmKU4GBWEuE99KM0Qog3JbGy KrUoP76oNCe1+BCjKdCpE5mlRJPzgQklryTe0MTQ3NLQyNjCwtzISEmct+TDlXAhgfTEktTs 1NSC1CKYPiYOTqkGxumxWVobjulMFI/ce8ji9CkxfuFVuXaBbxyaQ2+Ze6bWbq+UedP+/d6E bO4v/SyiCyYcuhlyM+gik4pTwzWBzMXuoTdVq94xLbm4oyFBwf7LZ73Oh+ouvJvEJwi0ngr8 +J27dfNhn3rTGRcZs3ad69Wy+JGzb89Kg1DmhXvebZKYvXNi/nspJyWW4oxEQy3mouJEAAID OrvwAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111093935eucas1p1545dba7154ece202e98e41c816bcd6b7 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170111063408epcas1p4b29b1308a0b8088afd46a475770d4b00 X-RootMTR: 20170111063408epcas1p4b29b1308a0b8088afd46a475770d4b00 References: <1484116439-7275-1-git-send-email-hoegeun.kwon@samsung.com> <1484116439-7275-4-git-send-email-hoegeun.kwon@samsung.com> <5875EF69.1070803@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.01.2017 09:40, Inki Dae wrote: > > 2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글: >> On 11.01.2017 07:33, Hoegeun Kwon wrote: >>> From: Hyungwon Hwang >>> >>> This patch add the panel device tree node for S6E3HA2 display >>> controller to TM2 dts. >>> >>> Signed-off-by: Hyungwon Hwang >>> Signed-off-by: Andrzej Hajda >>> Signed-off-by: Chanwoo Choi >>> Signed-off-by: Hoegeun Kwon >>> Tested-by: Chanwoo Choi >>> --- >>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> index ddba2f8..6d362f9 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> @@ -18,6 +18,18 @@ >>> compatible = "samsung,tm2", "samsung,exynos5433"; >>> }; >>> >>> +&dsi { >>> + panel@0 { >>> + compatible = "samsung,s6e3ha2"; >>> + reg = <0>; >>> + vdd3-supply = <&ldo27_reg>; >>> + vci-supply = <&ldo28_reg>; >>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >> The same here (as in 1st comment) , te-gpios should be dropper - decon >> uses hw-trigger. > Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together. > > Thanks. OK, I forgot it was not yet ported to mainline. Regards Andrzej > >> Regards >> Andrzej >>> + }; >>> +}; >>> + >>> &hsi2c_9 { >>> status = "okay"; >>> >> >> >> >