From: Krzysztof Kozlowski <krzk@kernel.org>
To: JeeHeng Sia <jeeheng.sia@starfivetech.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"conor@kernel.org" <conor@kernel.org>,
"kernel@esmil.dk" <kernel@esmil.dk>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"emil.renner.berthing@canonical.com"
<emil.renner.berthing@canonical.com>
Cc: "linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leyfoon Tan <leyfoon.tan@starfivetech.com>
Subject: Re: [PATCH 3/7] dt-bindings: timer: Add StarFive JH8100 clint
Date: Tue, 28 Nov 2023 08:19:51 +0100 [thread overview]
Message-ID: <5820442a-7819-488f-b389-8385531b510f@kernel.org> (raw)
In-Reply-To: <d72d6fa58309438385e14c3713918654@EXMBX066.cuchost.com>
On 28/11/2023 06:24, JeeHeng Sia wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Monday, November 27, 2023 4:48 PM
>> To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu;
>> conor@kernel.org; kernel@esmil.dk; robh+dt@kernel.org; emil.renner.berthing@canonical.com
>> Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan <leyfoon.tan@starfivetech.com>
>> Subject: Re: [PATCH 3/7] dt-bindings: timer: Add StarFive JH8100 clint
>>
>> On 27/11/2023 02:35, Sia Jee Heng wrote:
>>> Add compatible string for the StarFive JH8100 clint
>>>
>>> Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com>
>>> Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
>>> ---
>>
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC. It might happen, that command when run on an older
>> kernel, gives you outdated entries. Therefore please be sure you base
>> your patches on recent Linux kernel.
>>
>> You missed at least devicetree list (maybe more), so this won't be
>> tested by automated tooling. Performing review on untested code might be
>> a waste of time, thus I will skip this patch entirely till you follow
>> the process allowing the patch to be tested.
>>
>> Please kindly resend and include all necessary To/Cc entries.
> Noted. Should I resend the patches with the V1 tag and with addressed comments?
This was v1. Next one is v2.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-28 7:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 1:35 [PATCH 0/7] Initial device tree support for StarFive JH8100 SoC Sia Jee Heng
2023-11-27 1:35 ` [PATCH 1/7] dt-bindings: riscv: Add StarFive Dubhe compatibles Sia Jee Heng
2023-11-27 8:47 ` Krzysztof Kozlowski
2023-11-27 1:35 ` [PATCH 2/7] dt-bindings: riscv: Add StarFive JH8100 SoC Sia Jee Heng
2023-11-27 1:35 ` [PATCH 3/7] dt-bindings: timer: Add StarFive JH8100 clint Sia Jee Heng
2023-11-27 8:47 ` Krzysztof Kozlowski
2023-11-28 5:24 ` JeeHeng Sia
2023-11-28 7:19 ` Krzysztof Kozlowski [this message]
2023-11-28 7:56 ` JeeHeng Sia
2023-11-27 1:35 ` [PATCH 4/7] dt-bindings: interrupt-controller: Add StarFive JH8100 plic Sia Jee Heng
2023-11-27 8:48 ` Krzysztof Kozlowski
2023-11-27 1:36 ` [PATCH 5/7] dt-bindings: xilinx: Add StarFive compatible string Sia Jee Heng
2023-11-27 8:48 ` Krzysztof Kozlowski
2023-11-28 5:24 ` JeeHeng Sia
2023-11-27 1:36 ` [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive Sia Jee Heng
2023-11-27 8:49 ` Krzysztof Kozlowski
2023-11-28 5:25 ` JeeHeng Sia
2023-11-28 7:21 ` Krzysztof Kozlowski
2023-11-28 7:57 ` JeeHeng Sia
2023-11-27 1:36 ` [PATCH 7/7] riscv: dts: starfive: Add initial StarFive JH8100 device tree Sia Jee Heng
2023-11-27 8:50 ` Krzysztof Kozlowski
2023-11-27 9:20 ` Conor Dooley
2023-11-27 9:29 ` Krzysztof Kozlowski
2023-11-28 3:23 ` JeeHeng Sia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5820442a-7819-488f-b389-8385531b510f@kernel.org \
--to=krzk@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=jeeheng.sia@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®