From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752578AbcKHHop convert rfc822-to-8bit (ORCPT ); Tue, 8 Nov 2016 02:44:45 -0500 Received: from prv-mh.provo.novell.com ([137.65.248.74]:38508 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbcKHHoo (ORCPT ); Tue, 8 Nov 2016 02:44:44 -0500 Message-Id: <58219077020000780011CF59@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.1 Date: Tue, 08 Nov 2016 00:44:39 -0700 From: "Jan Beulich" To: , , "Juergen Gross" Cc: , Subject: [PATCH v2] xen/manage: correct return value check on xenbus_scanf() Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A negative return value indicates an error; in fact the function at present won't ever return zero. Signed-off-by: Jan Beulich --- v2: For consistency with other code don't consider zero an error (utilizing that xenbus_scanf() at present won't return zero). Adjust commit message accordingly. --- drivers/xen/manage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 4.9-rc4/drivers/xen/manage.c +++ 4.9-rc4-xen-manage-xenbus_scanf/drivers/xen/manage.c @@ -277,7 +277,7 @@ static void sysrq_handler(struct xenbus_ err = xenbus_transaction_start(&xbt); if (err) return; - if (!xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key)) { + if (xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key) < 0) { pr_err("Unable to read sysrq code in control/sysrq\n"); xenbus_transaction_end(xbt, 1); return;