From: Li Ming <ming.li@zohomail.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
dave@stgolabs.net, jonathan.cameron@huawei.com,
vishal.l.verma@intel.com, ira.weiny@intel.com,
dan.j.williams@intel.com, alison.schofield@intel.com
Subject: Re: [PATCH v2 0/7] Use guard() instead of rwsem locking
Date: Thu, 20 Feb 2025 08:43:21 +0800 [thread overview]
Message-ID: <58269f53-03a0-4cd4-9335-686c770b1f60@zohomail.com> (raw)
In-Reply-To: <07d8bd01-ed09-4106-81fb-0e7b6793e3aa@intel.com>
On 2/20/2025 5:09 AM, Dave Jiang wrote:
>
> On 2/17/25 7:48 AM, Li Ming wrote:
>> Use scoped resource management to replace open-coded locking operation
>> is recommended. CXL subsystem still remains some down_read()/up_read()
>> and down_write()/up_write() which can be replaced by guard() simply.
>>
>> This patchset includes simply using guard() instead of some
>> down_read()/up_read() and down_write()/up_write() cases. Besides, it
>> also includes some function code cleanup after using guard().
>>
>> base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3 (tag: v6.14-rc2)
>>
>> v2:
>> - Drop some local variables. (Jonathan)
>> - Rename __construct_region() to construct_auto_region(). (Jonathan and Dave)
> Hi Ming,
> Can you please do me a favor and rebase this against cxl/next for a v3? I think there are some conflicts against the DPA cleanup that's not easily resolved. Thanks!
>
> DJ
Sure, will do that.
Ming
prev parent reply other threads:[~2025-02-20 0:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 14:48 Li Ming
2025-02-17 14:48 ` [PATCH v2 1/7] cxl/core: Use guard() to replace open-coded down_read/write() Li Ming
2025-02-19 17:11 ` Dave Jiang
2025-02-19 17:33 ` Alison Schofield
2025-02-17 14:48 ` [PATCH v2 2/7] cxl/core: cxl_mem_sanitize() cleanup Li Ming
2025-02-19 17:12 ` Dave Jiang
2025-02-19 17:34 ` Alison Schofield
2025-02-17 14:48 ` [PATCH v2 3/7] cxl/memdev: cxl_memdev_ioctl() cleanup Li Ming
2025-02-19 17:16 ` Dave Jiang
2025-02-19 17:35 ` Alison Schofield
2025-02-17 14:48 ` [PATCH v2 4/7] cxl/core: Use guard() to drop the goto pattern of cxl_dpa_free() Li Ming
2025-02-19 17:19 ` Dave Jiang
2025-02-19 17:36 ` Alison Schofield
2025-02-17 14:48 ` [PATCH v2 5/7] cxl/core: Use guard() to drop goto pattern of cxl_dpa_alloc() Li Ming
2025-02-19 17:21 ` Dave Jiang
2025-02-19 17:36 ` Alison Schofield
2025-02-20 1:01 ` Dan Williams
2025-02-20 1:26 ` Li Ming
2025-02-20 1:29 ` Dan Williams
2025-02-17 14:48 ` [PATCH v2 6/7] cxl/region: Drop goto pattern in cxl_dax_region_alloc() Li Ming
2025-02-19 17:23 ` Dave Jiang
2025-02-19 17:37 ` Alison Schofield
2025-02-17 14:48 ` [PATCH v2 7/7] cxl/region: Drop goto pattern of construct_region() Li Ming
2025-02-18 17:24 ` Jonathan Cameron
2025-02-19 17:24 ` Dave Jiang
2025-02-19 17:38 ` Alison Schofield
2025-02-20 1:04 ` Dan Williams
2025-02-20 1:42 ` Li Ming
2025-02-18 17:54 ` [PATCH v2 0/7] Use guard() instead of rwsem locking Davidlohr Bueso
2025-02-19 20:46 ` Ira Weiny
2025-02-19 21:09 ` Dave Jiang
2025-02-20 0:43 ` Li Ming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58269f53-03a0-4cd4-9335-686c770b1f60@zohomail.com \
--to=ming.li@zohomail.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®