From: David Howells <dhowells@redhat.com>
To: Max Kellermann <mk@cm4all.com>
Cc: dhowells@redhat.com, linux-cachefs@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fscache: extended "dying" check before emitting EV_INVALIDATE
Date: Tue, 23 Apr 2013 17:57:46 +0100 [thread overview]
Message-ID: <5827.1366736266@warthog.procyon.org.uk> (raw)
In-Reply-To: <20130403144857.22351.67546.stgit@rabbit.intern.cm-ag>
Max Kellermann <mk@cm4all.com> wrote:
> Before emitting an FSCACHE_OBJECT_EV_INVALIDATE event, the function
> __fscache_invalidate() checks whether the fscache_object is currently
> "dying". This checks only the current state, not the queued events
> that will very soon lead to the object's death.
This should not be a problem, I think. EV_RETIRE and EV_RELEASE should only be
set by fscache_relinquish_cookie(). If you (the netfs) call that to dispose of
a cookie to fscache, you shouldn't thereafter be calling fscache_invalidate()
on it. The only case in which __fscache_invalidate() should see a dying object
is if the caching backend withdraws it (ie. EV_WITHDRAW is set).
Do you have a backtrace?
David
prev parent reply other threads:[~2013-04-23 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 14:48 Max Kellermann
2013-04-23 16:46 ` David Howells
2013-04-23 16:57 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5827.1366736266@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mk@cm4all.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®