From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965750AbbJ1N6m (ORCPT ); Wed, 28 Oct 2015 09:58:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:34683 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966236AbbJ1Nyl (ORCPT ); Wed, 28 Oct 2015 09:54:41 -0400 X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" From: Jiri Slaby To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Nicholas Mc Guire , Hans de Goede , Mauro Carvalho Chehab , Oliver Neukum , Jiri Slaby Subject: [PATCH 3.12 117/123] [media] gscpa_m5602: use msecs_to_jiffies for conversions Date: Wed, 28 Oct 2015 14:53:48 +0100 Message-Id: <582a72cd28521eabc4bebb29bbdc5ce0bf10c082.1446021556.git.jslaby@suse.cz> X-Mailer: git-send-email 2.6.2 In-Reply-To: <5584351853aa18c1d059ebc63948faa4aa0bbdd3.1446021555.git.jslaby@suse.cz> References: <5584351853aa18c1d059ebc63948faa4aa0bbdd3.1446021555.git.jslaby@suse.cz> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicholas Mc Guire 3.12-stable review patch. If anyone has any objections, please let me know. =============== commit 63f2f417526fc54191f2b813f72dc1d5322bede8 upstream. API compliance scanning with coccinelle flagged: ./drivers/media/usb/gspca/m5602/m5602_s5k83a.c:180:9-25: WARNING: timeout (100) seems HZ dependent Numeric constants passed to schedule_timeout() make the effective timeout HZ dependent which makes little sense in a polling loop for the cameras rotation state. Fixed up by converting the constant to jiffies with msecs_to_jiffies() Signed-off-by: Nicholas Mc Guire Signed-off-by: Hans de Goede Signed-off-by: Mauro Carvalho Chehab Cc: Oliver Neukum Signed-off-by: Jiri Slaby --- drivers/media/usb/gspca/m5602/m5602_s5k83a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c index 7cbc3a00bda8..bf6b215438e3 100644 --- a/drivers/media/usb/gspca/m5602/m5602_s5k83a.c +++ b/drivers/media/usb/gspca/m5602/m5602_s5k83a.c @@ -177,7 +177,7 @@ static int rotation_thread_function(void *data) __s32 vflip, hflip; set_current_state(TASK_INTERRUPTIBLE); - while (!schedule_timeout(100)) { + while (!schedule_timeout(msecs_to_jiffies(100))) { if (mutex_lock_interruptible(&sd->gspca_dev.usb_lock)) break; -- 2.6.2