From: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
To: Louis Chauvet <louis.chauvet@bootlin.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Melissa Wen <melissa.srw@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
nfraprado@collabora.com, pekka.paalanen@collabora.com,
daniels@collabora.com, kernel@collabora.com
Subject: Re: [PATCH] drm/vkms: Fix bad matrix offset component multiplication
Date: Tue, 10 Feb 2026 14:24:15 -0300 [thread overview]
Message-ID: <58373d82-d238-4302-b72a-3625b153bd9e@collabora.com> (raw)
In-Reply-To: <28d9f246-8952-4f03-94bc-60eadca78c2f@bootlin.com>
Hi Louis,
Sorry for the delay.
On 12/29/25 6:33 AM, Louis Chauvet wrote:
>
>
> On 12/23/25 18:26, Ariel D'Alessandro wrote:
>> Pixels values are packed as 16-bit UNORM values, so the matrix offset
>> components must be multiplied properly by the idempotent element -i.e.
>> number 1 encoded as 16-bit UNORM-.
>>
>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
>
> Hi,
>
> Thanks for this patch!
>
> How did you catch the issue? If you have an example of failing color
> conversion, can you add a test case in vkms_color_test?
I found it while working on this IGT tools patch series [0], this patch
in particular [1].
I've just added the related kunit test, so I'll send it as a v2 patchset.
[0]
https://lore.kernel.org/igt-dev/20251223-post-blend-colorops-v2-0-f40aca9795bd@collabora.com/
[1]
https://lore.kernel.org/igt-dev/20251223-post-blend-colorops-v2-7-f40aca9795bd@collabora.com/
Regards,
--
Ariel D'Alessandro
Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718
prev parent reply other threads:[~2026-02-10 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 17:26 Ariel D'Alessandro
2025-12-29 9:33 ` Louis Chauvet
2026-02-10 17:24 ` Ariel D'Alessandro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58373d82-d238-4302-b72a-3625b153bd9e@collabora.com \
--to=ariel.dalessandro@collabora.com \
--cc=airlied@gmail.com \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=melissa.srw@gmail.com \
--cc=mripard@kernel.org \
--cc=nfraprado@collabora.com \
--cc=pekka.paalanen@collabora.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®