mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yin, Fengwei" <fengwei.yin@intel.com>
To: kernel test robot <oliver.sang@intel.com>,
	wangkeqi <wangkeqiwang@didiglobal.com>
Cc: <oe-lkp@lists.linux.dev>, <lkp@intel.com>,
	<linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<ying.huang@intel.com>, <feng.tang@intel.com>
Subject: Re: [linus:master] [connector] c46bfba133: stress-ng.netlink-proc.ops_per_sec -97.2% regression
Date: Fri, 12 Jan 2024 19:28:17 +0800	[thread overview]
Message-ID: <5838205f-41ba-4666-9786-11181552a738@intel.com> (raw)
In-Reply-To: <202401112259.b23a1567-oliver.sang@intel.com>



On 1/11/2024 11:19 PM, kernel test robot wrote:
> 
> 
> Hello,
> 
> we reviewed this report and Fengwei (Cced) pointed out it could be the patch
> breaks functionality, then causes stress-ng netlink-proc performance drops
> dramatically.
> 
Just FYI. Here is what I observed when running
stress-ng.netlink-proc testing:

Whatever with/without the patch, cn_netlink_send_mult() returns
-ESRCH in most case.

The following is what the cn_netlink_send_mult() returns when
stress-ng.netlink-proc is running:

...
213801  213801  stress-ng-3     cn_netlink_send_mult -3
213801  213801  stress-ng-spawn cn_netlink_send_mult -3
213801  213801  stress-ng-spawn cn_netlink_send_mult -3
213801  213801  stress-ng-wait  cn_netlink_send_mult -3
213802  213802  stress-ng-4     cn_netlink_send_mult -3
213802  213802  stress-ng-spawn cn_netlink_send_mult -3
213802  213802  stress-ng-spawn cn_netlink_send_mult -3
213802  213802  stress-ng-wait  cn_netlink_send_mult -3
213803  213803  stress-ng-5     cn_netlink_send_mult -3
213803  213803  stress-ng-dead  cn_netlink_send_mult -3
213803  213803  stress-ng-dead  cn_netlink_send_mult -3
213802  213802  stress-ng-wait  cn_netlink_send_mult -3
213801  213801  stress-ng-wait  cn_netlink_send_mult -3
213800  213800  stress-ng-wait  cn_netlink_send_mult -3
213799  213799  stress-ng-wait  cn_netlink_send_mult -3
213798  213798  stress-ng-wait  cn_netlink_send_mult -3
154697  154697  stress-ng       cn_netlink_send_mult -3
...


Looks like it's not accurate to reset proc_event_num_listeners
according to cn_netlink_send_mult() return value -3.


Regards
Yin, Fengwei

  reply	other threads:[~2024-01-12 11:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 15:19 kernel test robot
2024-01-12 11:28 ` Yin, Fengwei [this message]
2024-01-13  8:56   ` 王珂琦 Keqi Wang Wang
2024-01-15  2:22     ` Yin, Fengwei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5838205f-41ba-4666-9786-11181552a738@intel.com \
    --to=fengwei.yin@intel.com \
    --cc=davem@davemloft.net \
    --cc=feng.tang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=wangkeqiwang@didiglobal.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®