From: Laxman Dewangan <ldewangan@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: <linus.walleij@linaro.org>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <swarren@wwwdotorg.org>,
<gnurou@gmail.com>, <joe@perches.com>,
<yamada.masahiro@socionext.com>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads
Date: Mon, 28 Nov 2016 14:52:07 +0530 [thread overview]
Message-ID: <583BF73F.7010407@nvidia.com> (raw)
In-Reply-To: <4d255a3e-0816-498c-a280-6d29ca880e13@nvidia.com>
On Monday 28 November 2016 02:56 PM, Jon Hunter wrote:
> On 25/11/16 17:49, Laxman Dewangan wrote:
>>
>> In the above dpaux driver, you used the pinctrl framework and its core
>> functionality for the device tree interfacing and client interfacing.
>>
>> The same thing I am saying here, we should not avoid the pinctrl
>> framework. The client driver will use the pinctrl framework for the IO
>> pad configurations, not direct PMC APIs.
> Exactly, so why are you saying that by moving the code into the PMC
> driver this will "need lots of DT processing for getting information
> from DT"? By moving the code, we are not suggesting we don't use the
> pinctrl framework, we are just suggesting we move the code. That's all.
>
>
OK, got it. My understanding from suggestion was that to implement
everything without using the pinctrl framework.
I dont see much issue to just move this to drivers/soc/tegra folder
I hope rest of stuff will be same, registering it as subdev of the pmc
and this io pad driver will be the platform driver.
next prev parent reply other threads:[~2016-11-28 9:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 8:38 [PATCH V4 0/2] pinctrl: tegra: Add support for IO pad control Laxman Dewangan
2016-11-24 8:38 ` [PATCH V4 1/2] pinctrl: tegra: Add DT binding for io pads control Laxman Dewangan
2016-11-25 9:13 ` Thierry Reding
2016-11-25 11:40 ` Laxman Dewangan
2016-11-25 17:19 ` Jon Hunter
2016-11-24 8:38 ` [PATCH V4 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads Laxman Dewangan
2016-11-25 9:57 ` Thierry Reding
2016-11-25 12:04 ` Laxman Dewangan
2016-11-25 17:29 ` Jon Hunter
2016-11-25 17:49 ` Laxman Dewangan
2016-11-28 9:26 ` Jon Hunter
2016-11-28 9:22 ` Laxman Dewangan [this message]
2016-11-25 17:26 ` Jon Hunter
2016-11-25 17:45 ` Laxman Dewangan
2016-11-28 9:31 ` Jon Hunter
2016-12-04 3:31 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583BF73F.7010407@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=joe@perches.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome