From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751596AbdEBJTG (ORCPT ); Tue, 2 May 2017 05:19:06 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:32788 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbdEBJRX (ORCPT ); Tue, 2 May 2017 05:17:23 -0400 Subject: Re: [PATCH v8 05/10] media: venus: adding core part and helper functions To: Bjorn Andersson , Mauro Carvalho Chehab , Hans Verkuil , Andy Gross , Stephen Boyd , Srinivas Kandagatla , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <1493370837-19793-1-git-send-email-stanimir.varbanov@linaro.org> <1493370837-19793-6-git-send-email-stanimir.varbanov@linaro.org> <20170428220245.GA3283@jcrouse-lnx.qualcomm.com> <20170429202247.GV15143@minitux> From: Stanimir Varbanov Message-ID: <5840407a-8812-65a9-5716-f3a64427649b@linaro.org> Date: Tue, 2 May 2017 12:17:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170429202247.GV15143@minitux> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 04/29/2017 11:22 PM, Bjorn Andersson wrote: > On Fri 28 Apr 15:02 PDT 2017, Jordan Crouse wrote: > >> On Fri, Apr 28, 2017 at 12:13:52PM +0300, Stanimir Varbanov wrote: >>> +int venus_boot(struct device *parent, struct device *fw_dev) >>> +{ >>> + const struct firmware *mdt; >>> + phys_addr_t mem_phys; >>> + ssize_t fw_size; >>> + size_t mem_size; >>> + void *mem_va; >>> + int ret; >>> + >>> + if (!qcom_scm_is_available()) >>> + return -EPROBE_DEFER; >>> + >>> + fw_dev->parent = parent; >>> + fw_dev->release = device_release_dummy; >>> + >>> + ret = dev_set_name(fw_dev, "%s:%s", dev_name(parent), "firmware"); >>> + if (ret) >>> + return ret; >>> + >>> + ret = device_register(fw_dev); >>> + if (ret < 0) >>> + return ret; >>> + >>> + ret = of_reserved_mem_device_init_by_idx(fw_dev, parent->of_node, 0); >>> + if (ret) >>> + goto err_unreg_device; >>> + >>> + mem_size = VENUS_FW_MEM_SIZE; >>> + >>> + mem_va = dmam_alloc_coherent(fw_dev, mem_size, &mem_phys, GFP_KERNEL); >>> + if (!mem_va) { >>> + ret = -ENOMEM; >>> + goto err_unreg_device; >>> + } >>> + >>> + ret = request_firmware(&mdt, VENUS_FIRMWARE_NAME, fw_dev); >>> + if (ret < 0) >>> + goto err_unreg_device; >>> + >>> + fw_size = qcom_mdt_get_size(mdt); >>> + if (fw_size < 0) { >>> + ret = fw_size; >>> + release_firmware(mdt); >>> + goto err_unreg_device; >>> + } >>> + >>> + ret = qcom_mdt_load(fw_dev, mdt, VENUS_FIRMWARE_NAME, VENUS_PAS_ID, >>> + mem_va, mem_phys, mem_size); >>> + >>> + release_firmware(mdt); >>> + >>> + if (ret) >>> + goto err_unreg_device; >>> + >>> + ret = qcom_scm_pas_auth_and_reset(VENUS_PAS_ID); >>> + if (ret) >>> + goto err_unreg_device; >>> + >>> + return 0; >>> + >>> +err_unreg_device: >>> + device_unregister(fw_dev); >>> + return ret; >>> +} >> >> Hey, this looks familiar - almost line for line identical to what we'll need to >> do for GPU. >> >> Bjorn - Is this enough to qualify for generic status in the mdt_loader code? >> I know its just two consumers, but it would save 50 or 60 lines of code between >> the two drivers and be easier to maintain. >> > > I think the code setting up the struct device for memory allocation > should be done during probe of the parent, so that I don't think should > be shared. > > The part that allocates memory from a device, loads the mdt into that > memory and calls auth_and_reset() sounds like a useful thing to move to > the mdt_loader.c I agree, who is going to do that? -- regards, Stan