From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751772AbbJWOXT (ORCPT ); Fri, 23 Oct 2015 10:23:19 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:56280 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbbJWOXS (ORCPT ); Fri, 23 Oct 2015 10:23:18 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Eric Auger , b.reynal@virtualopensystems.com, kvm@vger.kernel.org, patches@linaro.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, eric.auger@st.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org Subject: Re: [PATCH v3 6/7] vfio: platform: use list of registered reset function Date: Fri, 23 Oct 2015 16:23:06 +0200 Message-ID: <5844194.uTAR9RVtmZ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <562A3FFC.4050504@linaro.org> References: <1445603835-14506-1-git-send-email-eric.auger@linaro.org> <4934120.DeNtNjTIFs@wuerfel> <562A3FFC.4050504@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:aOkhwiHEsORone4SlMMtu9idzp6iT1G/r34HxmESWUV49Zn1ws2 sKdEF1VnI8oT3DXRWM40y+U/Yq8avgRjdFGqfGRkIM5XeBK+CacmM6LS8V24fyF+VcgnIN9 Pj5vRzDSh2LAKS7ce7VG1/0hPvm1lwbyT3qe38O4Keo5DjiNALjdEKwCuAiFiW7XNA+vKr+ sy4gRRCrWkgCCWCsmQRHw== X-UI-Out-Filterresults: notjunk:1;V01:K0:a+8xRknNgcg=:f5rMHDUApXuGHhV1mNsi4z v7lus9oHc5xwB7hGjc7R6QuwnFTYoNuKldRBeavtEfLvU9z9jDBVxUoCXKe4Ung8CQMWtT4YQ zRJOonCY85e7ftADK1MJ/cSAioKmBgHfzbyMumy8c+fI+YgF+m3Z0aGWDR7rHGzm7tfdhaEVg QNznsHGZaIc7dJvHdw9c9MOywqZcZGwRjFvq8myOKcfoFz32pdtIfHtpvX7bcSr8ZTbYb81j/ 5Ba5vC6weDf68jFFhdbYN2jKwedBlTiij9g3xnkmRohujk+gmEkadzJuncpaqYJcP8fgRZ53l 1t+bp4l0YhCZtizJr3wfJEOt1lJFVihzj8jeALKtmaB7lQPvDesji42Kn1N/9hVBgAd99/Ae1 4ggg48aUCD68MHvS6+i5LjYLX1/AVyEtXJ5DpWAdHYgRvUWfXPM4t7xAFgYS3wLl9YIAa7t1e o80RqHLrHoFz3VQkzzNBOw7MVkX2uOfZHSp4DgfRaEcsZUaG2Ir/51/KgKLiycnTt4Viw+I5Y sj8XfeKitEdUxZqYCWqpilINLV27rLLwlxofAYKTzZRfhYbeeVevBWHx77ZEAEM7aC1AA/dHn /Phl6+0vs1Id6JkhTzE/akRce36oq9KCu5FLdv3w+kg9oaT2mdQyGAKeRORdXchr0mQrWkGtA y0N7amknzRDALD4/1mnG6kxkLGfe75IJYQLPXLndi+L8k+C/emmhftezuKf/TGGYqeH66pwQ9 dHIvUW6nWYCBt2sq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 23 October 2015 16:11:08 Eric Auger wrote: > Hi Arnd, > On 10/23/2015 03:12 PM, Arnd Bergmann wrote: > > On Friday 23 October 2015 14:37:14 Eric Auger wrote: > >> Remove the static lookup table and use the dynamic list of registered > >> reset functions instead. Also load the reset module through its alias. > >> The reset struct module pointer is stored in vfio_platform_device. > >> > >> We also remove the useless struct device pointer parameter in > >> vfio_platform_get_reset. > >> > >> This patch fixes the issue related to the usage of __symbol_get, which > >> besides from being moot, prevented compilation with CONFIG_MODULES > >> disabled. > >> > >> Also usage of MODULE_ALIAS makes possible to add a new reset module > >> without needing to update the framework. This was suggested by Arnd. > >> > >> Signed-off-by: Eric Auger > >> Reported-by: Arnd Bergmann > >> > >> > > Reviewed-by: Arnd Bergmann > > > > but doesn't this need to come before patch 4/7? > Well I don't think so. In [4] we introduce the dynamic registration > method but until this patch we still use the old lookup method in the > static table. I tested and the reset lookup still works in [4]. > If we put this one before the registration, the functionality will be > lost here. > Ok, I see. I was getting confused by the removal of the EXPORT_SYMBOL statement there and thought it would break the __get_symbol call. Arnd