From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: <viro@zeniv.linux.org.uk>, <rostedt@goodmis.org>,
<mingo@redhat.com>, "Jens Axboe" <axboe@kernel.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>
Cc: <jack@suse.cz>, <tj@kernel.org>, <bigeasy@linutronix.de>,
linfeilong <linfeilong@huawei.com>,
Yanxiaodan <yanxiaodan@huawei.com>,
Mingfangsen <mingfangsen@huawei.com>,
renxudong <renxudong1@huawei.com>
Subject: [PATCH] buffer: remove useless comment and WB_REASON_FREE_MORE_MEM, reason.
Date: Mon, 13 Apr 2020 13:12:10 +0800 [thread overview]
Message-ID: <5844aa66-de1e-278b-5491-b7e6839640e9@huawei.com> (raw)
From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
free_more_memory func has been completely removed in commit bc48f001de12
("buffer: eliminate the need to call free_more_memory() in __getblk_slow()")
So comment and `WB_REASON_FREE_MORE_MEM` reason about free_more_memory
are no longer needed.
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
---
fs/buffer.c | 2 +-
include/linux/backing-dev-defs.h | 1 -
include/trace/events/writeback.h | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index b8d28370cfd7..07ab0405f3f5 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -973,7 +973,7 @@ grow_dev_page(struct block_device *bdev, sector_t block,
struct page *page;
struct buffer_head *bh;
sector_t end_block;
- int ret = 0; /* Will call free_more_memory() */
+ int ret = 0;
gfp_t gfp_mask;
gfp_mask = mapping_gfp_constraint(inode->i_mapping, ~__GFP_FS) | gfp;
diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
index 4fc87dee005a..ee577a83cfe6 100644
--- a/include/linux/backing-dev-defs.h
+++ b/include/linux/backing-dev-defs.h
@@ -54,7 +54,6 @@ enum wb_reason {
WB_REASON_SYNC,
WB_REASON_PERIODIC,
WB_REASON_LAPTOP_TIMER,
- WB_REASON_FREE_MORE_MEM,
WB_REASON_FS_FREE_SPACE,
/*
* There is no bdi forker thread any more and works are done
diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
index d94def25e4dc..85a33bea76f1 100644
--- a/include/trace/events/writeback.h
+++ b/include/trace/events/writeback.h
@@ -36,7 +36,6 @@
EM( WB_REASON_SYNC, "sync") \
EM( WB_REASON_PERIODIC, "periodic") \
EM( WB_REASON_LAPTOP_TIMER, "laptop_timer") \
- EM( WB_REASON_FREE_MORE_MEM, "free_more_memory") \
EM( WB_REASON_FS_FREE_SPACE, "fs_free_space") \
EMe(WB_REASON_FORKER_THREAD, "forker_thread")
--
2.19.1
next reply other threads:[~2020-04-13 5:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 5:12 Zhiqiang Liu [this message]
2020-04-14 15:09 ` Jan Kara
2020-04-18 1:01 ` Zhiqiang Liu
2020-04-18 3:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5844aa66-de1e-278b-5491-b7e6839640e9@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=jack@suse.cz \
--cc=linfeilong@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=mingo@redhat.com \
--cc=renxudong1@huawei.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yanxiaodan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®