mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julien Panis <jpanis@baylibre.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh@kernel.org>
Cc: lee@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	corbet@lwn.net, arnd@arndb.de, gregkh@linuxfoundation.org,
	derek.kiernan@xilinx.com, dragan.cvetic@xilinx.com,
	eric.auger@redhat.com, jgg@ziepe.ca, razor@blackwall.org,
	stephen@networkplumber.org, davem@davemloft.net,
	christian.koenig@amd.com, contact@emersion.fr,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, sterzik@ti.com, u-kumar1@ti.com,
	eblanc@baylibre.com, jneanne@baylibre.com
Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC
Date: Tue, 21 Mar 2023 11:48:06 +0100	[thread overview]
Message-ID: <5845f51e-5d87-c98e-77a1-0f9b6365e6c1@baylibre.com> (raw)
In-Reply-To: <2aeb47d6-0577-f8e4-6070-331af15b1f83@linaro.org>



On 3/21/23 11:32, Krzysztof Kozlowski wrote:
> On 21/03/2023 10:03, Julien Panis wrote:
>>
>> On 3/21/23 08:36, Krzysztof Kozlowski wrote:
>>> On 20/03/2023 17:35, Julien Panis wrote:
>>>> On 3/20/23 16:53, Rob Herring wrote:
>>>>> On Wed, Mar 15, 2023 at 12:07:33PM +0100, Julien Panis wrote:
>>>>>> TPS6594 is a Power Management IC which provides regulators and others
>>>>>> features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
>>>>>> PFSM (Pre-configurable Finite State Machine) managing the state of the
>>>>>> device.
>>>>>> TPS6594 is the super-set device while TPS6593 and LP8764X are derivatives.
>>>>> As mentioned, the binding needs to be complete. It's missing GPIO at
>>>>> least. RTC and watchdog may or may not need binding changes.
>>>> Thank you for your feedback.
>>>>
>>>> About GPIO, do you speak about 'gpio-controller'
>>>> and/or '#gpio-cells' properties ?
>>> Yes.
>>>
>>>> For RTC (and for watchdog, once the driver will be
>>>> implemented), our driver do not require any node
>>>> to work. What could make an explicit instantiation
>>>> necessary in DT ?
>>> Properties from RTC schema, e.g. start-year, wakeup etc.
>> TPS6594 RTC driver is being reviewed (this is another patch
>> series, not merged yet). These properties are not used by our
>> driver, that's why we did not have to add some RTC node in
>> the DT (until now, using such properties in our driver was not
>> requested by RTC sub-system maintainers).
> Bindings should be complete, regardless whether you now need this in
> driver or not. Does your comment mean that you will never need these,
> because hardware does not support them, and never going to add?
> Otherwise I don't get why you refer to driver when we talk about bindings...

OK, I understand now (I misinterpreted "RTC and watchdog may or may not
need binding changes").

> Best regards,
> Krzysztof
>


  reply	other threads:[~2023-03-21 10:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 11:07 [PATCH v2 0/4] TI TPS6594 PMIC support (Core, ESM, PFSM) Julien Panis
2023-03-15 11:07 ` [PATCH v2 1/4] dt-bindings: mfd: Add TI TPS6594 PMIC Julien Panis
2023-03-20 15:53   ` Rob Herring
2023-03-20 16:35     ` Julien Panis
2023-03-21  7:36       ` Krzysztof Kozlowski
2023-03-21  9:03         ` Julien Panis
2023-03-21 10:32           ` Krzysztof Kozlowski
2023-03-21 10:48             ` Julien Panis [this message]
2023-03-21 16:37     ` [EXTERNAL] " Sterzik, Chris
2023-03-15 11:07 ` [PATCH v2 2/4] mfd: tps6594: Add driver for " Julien Panis
2023-03-16 16:20   ` Lee Jones
2023-03-15 11:07 ` [PATCH v2 3/4] misc: tps6594-esm: Add driver for TI TPS6594 ESM Julien Panis
2023-03-15 11:07 ` [PATCH v2 4/4] misc: tps6594-pfsm: Add driver for TI TPS6594 PFSM Julien Panis
2023-03-15 11:34   ` Greg KH
2023-03-15 11:48     ` Julien Panis
2023-03-20 15:40 ` [PATCH v2 0/4] TI TPS6594 PMIC support (Core, ESM, PFSM) Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5845f51e-5d87-c98e-77a1-0f9b6365e6c1@baylibre.com \
    --to=jpanis@baylibre.com \
    --cc=arnd@arndb.de \
    --cc=christian.koenig@amd.com \
    --cc=contact@emersion.fr \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=derek.kiernan@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dragan.cvetic@xilinx.com \
    --cc=eblanc@baylibre.com \
    --cc=eric.auger@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jgg@ziepe.ca \
    --cc=jneanne@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=razor@blackwall.org \
    --cc=robh@kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=sterzik@ti.com \
    --cc=u-kumar1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®