From: Mike Travis <mike.travis@hpe.com>
To: Jiri Slaby <jslaby@suse.cz>, bp@alien8.de
Cc: linux-kernel@vger.kernel.org,
Dimitri Sivanich <dimitri.sivanich@hpe.com>,
Steve Wahl <steve.wahl@hpe.com>,
Russ Anderson <russ.anderson@hpe.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/platform/uv: drop last traces of uv_flush_tlb_others
Date: Mon, 9 Nov 2020 07:07:23 -0800 [thread overview]
Message-ID: <5847a155-cb70-7795-235b-746a57f2dac2@hpe.com> (raw)
In-Reply-To: <20201109093653.2042-1-jslaby@suse.cz>
Thanks Jiri for catching that.
Acked-By: Mike Travis <mike.travis@hpe.com>
On 11/9/2020 1:36 AM, Jiri Slaby wrote:
> Commit 39297dde7390 ("x86/platform/uv: Remove UV BAU TLB Shootdown
> Handler") removed uv_flush_tlb_others. Its declaration was removed also
> from asm/uv/uv.h. But only for the CONFIG_X86_UV=y case. The inline
> definition (!X86_UV case) is still in place.
>
> So remove this implementation with everything what was added to support
> uv_flush_tlb_others:
> * include of asm/tlbflush.h
> * forward declarations of struct cpumask, mm_struct, and flush_tlb_info
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Mike Travis <mike.travis@hpe.com>
> Cc: Dimitri Sivanich <dimitri.sivanich@hpe.com>
> Cc: Steve Wahl <steve.wahl@hpe.com>
> Cc: Russ Anderson <russ.anderson@hpe.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: x86@kernel.org
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> ---
> arch/x86/include/asm/uv/uv.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h
> index 172d3e4a9e4b..648eb23fe7f0 100644
> --- a/arch/x86/include/asm/uv/uv.h
> +++ b/arch/x86/include/asm/uv/uv.h
> @@ -2,14 +2,8 @@
> #ifndef _ASM_X86_UV_UV_H
> #define _ASM_X86_UV_UV_H
>
> -#include <asm/tlbflush.h>
> -
> enum uv_system_type {UV_NONE, UV_LEGACY_APIC, UV_X2APIC};
>
> -struct cpumask;
> -struct mm_struct;
> -struct flush_tlb_info;
> -
> #ifdef CONFIG_X86_UV
> #include <linux/efi.h>
>
> @@ -44,10 +38,6 @@ static inline int is_uv_system(void) { return 0; }
> static inline int is_uv_hubbed(int uv) { return 0; }
> static inline void uv_cpu_init(void) { }
> static inline void uv_system_init(void) { }
> -static inline const struct cpumask *
> -uv_flush_tlb_others(const struct cpumask *cpumask,
> - const struct flush_tlb_info *info)
> -{ return cpumask; }
>
> #endif /* X86_UV */
>
>
next prev parent reply other threads:[~2020-11-09 15:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:36 Jiri Slaby
2020-11-09 15:07 ` Mike Travis [this message]
2020-11-09 16:00 ` Steve Wahl
2020-11-11 12:22 ` [tip: x86/urgent] x86/platform/uv: Drop " tip-bot2 for Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5847a155-cb70-7795-235b-746a57f2dac2@hpe.com \
--to=mike.travis@hpe.com \
--cc=bp@alien8.de \
--cc=dimitri.sivanich@hpe.com \
--cc=hpa@zytor.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=russ.anderson@hpe.com \
--cc=steve.wahl@hpe.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®